Add more VerifyResult states

src/neo/Ledger/VerifyResult.cs

@@ -42,6 +42,26 @@ public enum VerifyResult : byte
         /// </summary>
         Invalid,
 
+        /// <summary>
+        /// Indicates that the <see cref="Transaction"/> has an invalid script.
+        /// </summary>
+        InvalidScript,
+
+        /// <summary>
+        /// Indicates that the <see cref="Transaction"/> has an invalid attribute.
+        /// </summary>
+        InvalidAttribute,
+
+        /// <summary>
+        /// Indicates that the <see cref="IInventory"/> has an invalid signature.
+        /// </summary>
+        InvalidSignature,
+
+        /// <summary>
+        /// Indicates that the size of the <see cref="IInventory"/> is not allowed.
+        /// </summary>
+        OverSize,
+
         /// <summary>
         /// Indicates that the <see cref="Transaction"/> has expired.
         /// </summary>

src/neo/Network/P2P/Payloads/Transaction.cs

@@ -364,7 +364,7 @@ public virtual VerifyResult VerifyStateDependent(ProtocolSettings settings, Data
             if (!(context?.CheckTransaction(this, snapshot) ?? true)) return VerifyResult.InsufficientFunds;
             foreach (TransactionAttribute attribute in Attributes)
                 if (!attribute.Verify(snapshot, this))
-                    return VerifyResult.Invalid;
+                    return VerifyResult.InvalidAttribute;
             long net_fee = NetworkFee - Size * NativeContract.Policy.GetFeePerByte(snapshot);
             if (net_fee < 0) return VerifyResult.InsufficientFunds;
 
@@ -396,14 +396,14 @@ public virtual VerifyResult VerifyStateDependent(ProtocolSettings settings, Data
         /// <returns>The result of the verification.</returns>
         public virtual VerifyResult VerifyStateIndependent(ProtocolSettings settings)
         {
-            if (Size > MaxTransactionSize) return VerifyResult.Invalid;
+            if (Size > MaxTransactionSize) return VerifyResult.OverSize;
             try
             {
                 _ = new Script(Script, true);
             }
             catch (BadScriptException)
             {
-                return VerifyResult.Invalid;
+                return VerifyResult.InvalidScript;
             }
             UInt160[] hashes = GetScriptHashesForVerifying(null);
             for (int i = 0; i < hashes.Length; i++)
@@ -415,7 +415,7 @@ public virtual VerifyResult VerifyStateIndependent(ProtocolSettings settings)
                     try
                     {
                         if (!Crypto.VerifySignature(this.GetSignData(settings.Network), witnesses[i].InvocationScript.AsSpan(2), pubkey, ECCurve.Secp256r1))
-                            return VerifyResult.Invalid;
+                            return VerifyResult.InvalidSignature;
                     }
                     catch
                     {
@@ -437,7 +437,7 @@ public virtual VerifyResult VerifyStateIndependent(ProtocolSettings settings)
                                 x++;
                             y++;
                             if (m - x > n - y)
-                                return VerifyResult.Invalid;
+                                return VerifyResult.InvalidSignature;
                         }
                     }
                     catch

tests/neo.UnitTests/Network/P2P/Payloads/UT_Transaction.cs

@@ -1141,7 +1141,7 @@ public void Test_VerifyStateIndependent()
                     }
                 }
             };
-            tx.VerifyStateIndependent(ProtocolSettings.Default).Should().Be(VerifyResult.Invalid);
+            tx.VerifyStateIndependent(ProtocolSettings.Default).Should().Be(VerifyResult.OverSize);
             tx.Script = Array.Empty<byte>();
             tx.VerifyStateIndependent(ProtocolSettings.Default).Should().Be(VerifyResult.Succeed);