-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add murmur32
to crypto lib
#2604
add murmur32
to crypto lib
#2604
Conversation
We need to have a mechanism to update the native contract manifest first. Otherwise, we cannot add or delete methods in the native contract. |
Maybe we may need to do an onchain transaction that activate this manifest update (following neo/src/neo/SmartContract/Native/NativeContract.cs Lines 145 to 160 in b3b2207
In this sense, method becomes available to be called as soon as we call this update function (maybe signed by Neo Council). |
But the manifet it will be updated with |
According to my test results, the unit fee of
|
After testing, change to |
It makes no sense, murmer shoud be way more efficient than SHA....... can we just hold this for a while? I need to dig into this. |
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
@Liaojinghui Merge? |
Yes please. |
* Add ToJson overload (#2671) * Add ToJson overload * change * Update src/neo/VM/Helper.cs * Update src/neo/VM/Helper.cs * Update src/neo/VM/Helper.cs * Update src/neo/VM/Helper.cs Co-authored-by: Jinghui Liao <jinghui@wayne.edu> * Update src/neo/VM/Helper.cs Co-authored-by: Jinghui Liao <jinghui@wayne.edu> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Jinghui Liao <jinghui@wayne.edu> * Fix oom (#2665) * Fix oom * Revert reorder * parameters order Co-authored-by: Erik Zhang <erik@neo.org> * Optimize inventory (#2659) * add `murmur32` to crypto lib (#2604) * 3.2.0 * fix Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Jinghui Liao <jinghui@wayne.edu>
Add efficient hash function