Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new WitnessScope: Rules #2622

Merged
merged 11 commits into from
Nov 9, 2021
Merged

Add new WitnessScope: Rules #2622

merged 11 commits into from
Nov 9, 2021

Conversation

erikzhang
Copy link
Member

Replace #2596

@erikzhang erikzhang mentioned this pull request Nov 7, 2021
@Jim8y
Copy link
Contributor

Jim8y commented Nov 7, 2021

Why conditions are under the payload folder? Too many files in this folder, and it is hard to locate the condition files.

@erikzhang
Copy link
Member Author

Why conditions are under the payload folder? Too many files in this folder, and it is hard to locate the condition files.

I've moved them to a new namespace.

Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this design, @erikzhang.
Much more flexible and powerful.

@roman-khimov
Copy link
Contributor

It's an interesting generalization that seems to cover #2583 problem well and also cases discussed in #2596. My primary concern would be is this simple enough to explain to developers that are gonna create transactions using this scope?

@Jim8y
Copy link
Contributor

Jim8y commented Nov 8, 2021

My primary concern would be is this simple enough to explain to developers that are gonna create transactions using this scope?

We need documents and samples for this~~

@shargon
Copy link
Member

shargon commented Nov 9, 2021

The code looks good, but what about something like a verification script. We push The Calling, Current and ExecutingHash (3 ByteString) and the script returns if it's allowed or not?

@erikzhang
Copy link
Member Author

The code looks good, but what about something like a verification script. We push The Calling, Current and ExecutingHash (3 ByteString) and the script returns if it's allowed or not?

Then we have to consider issues such as endless loops and permissions.

@erikzhang erikzhang merged commit 01f77d8 into master Nov 9, 2021
@erikzhang erikzhang deleted the witness-rules branch November 9, 2021 17:30
@superboyiii superboyiii mentioned this pull request Nov 10, 2021
13 tasks
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Nov 12, 2021
See neo-project/neo#2622. The implementation is somewhat asymmetric (and not
very efficient) for binary/JSON encoding/decoding, but it should be
sufficient.
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Nov 12, 2021
See neo-project/neo#2622. The implementation is somewhat asymmetric (and not
very efficient) for binary/JSON encoding/decoding, but it should be
sufficient.
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Nov 24, 2021
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Nov 24, 2021
* add witness rules (neo-project/neo#2622)

* Fix linting + type checking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants