-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new WitnessScope: Rules #2622
Conversation
Why conditions are under the payload folder? Too many files in this folder, and it is hard to locate the condition files. |
I've moved them to a new namespace. |
src/neo/Network/P2P/Payloads/Conditions/CalledByGroupCondition.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this design, @erikzhang.
Much more flexible and powerful.
We need documents and samples for this~~ |
The code looks good, but what about something like a verification script. We push The Calling, Current and ExecutingHash (3 ByteString) and the script returns if it's allowed or not? |
Then we have to consider issues such as endless loops and permissions. |
See neo-project/neo#2622. The implementation is somewhat asymmetric (and not very efficient) for binary/JSON encoding/decoding, but it should be sufficient.
See neo-project/neo#2622. The implementation is somewhat asymmetric (and not very efficient) for binary/JSON encoding/decoding, but it should be sufficient.
* add witness rules (neo-project/neo#2622) * Fix linting + type checking
Replace #2596