-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dos 2723 and prevent further price related dos attacks #2724
Conversation
I did not update src/neo/SmartContract/Helper.cs cause ordinary operations are not likely to trigger the *10 price.....to be honest, i dont think anyone other than hackers would trigger *10 price |
Why the UT fails? |
I don't think this solves the problem. When the count of opcodes reaches |
And several "problematic" opcodes can be hammered on even in a single transaction. |
Reaching the |
The |
But this introduces non-deterministic prices. |
We just count the number of each opcode then. |
I will close this pr since it doesn't solve the problem. And neo-project/neo-vm#471 should fix #2723. |
close neo-project/neo-vm#458
fix #2723
Dynamic opcode price strategy