Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference counting for native contracts #2732

Merged
merged 3 commits into from
May 12, 2022
Merged

Conversation

erikzhang
Copy link
Member

@erikzhang
Copy link
Member Author

@ixje It should fix neo-project/neo-vm#447, please have a look.

@erikzhang
Copy link
Member Author

erikzhang commented May 12, 2022

Merge? @roman-khimov

Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good for me

@roman-khimov
Copy link
Contributor

It's OK, even though I'd still prefer to keep removing items before delving into the handler logic. At least it solves a real problem C# node currently has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants