Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IDiagnostic interface #2735

Merged
merged 4 commits into from
May 13, 2022
Merged

Add IDiagnostic interface #2735

merged 4 commits into from
May 13, 2022

Conversation

erikzhang
Copy link
Member

No description provided.

@erikzhang erikzhang changed the title Move the diagnostic logic into the Diagnostic class Improve diagnostic for ApplicationEngine May 13, 2022
@erikzhang erikzhang mentioned this pull request May 13, 2022
Merged
@erikzhang erikzhang changed the title Improve diagnostic for ApplicationEngine Add IDiagnostic interface May 13, 2022
@erikzhang erikzhang marked this pull request as ready for review May 13, 2022 08:27
@erikzhang erikzhang mentioned this pull request May 13, 2022
Closed
@erikzhang erikzhang merged commit f83720e into develop May 13, 2022
@erikzhang erikzhang deleted the improve-diagnostic branch May 13, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikzhang @shargon