Fix AES256Encrypt Bug in OSX #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
previously approved these changes
May 19, 2022
|
Maybe we should update the workflow to run UTs in OSX. |
|
Test pass on my Mac M1 Pro machine. |
Jim8y
previously approved these changes
May 19, 2022
|
Considering the performance, I will be compatible with the original design because the system native library is faster |
Done. |
shargon
previously approved these changes
May 20, 2022
erikzhang
requested changes
May 20, 2022
Jim8y
approved these changes
May 20, 2022
erikzhang
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.