Cache not found keys #2744
Merged
Cache not found keys #2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it really solve #2720? One can just use random unique hash/group in each rule entry. |
But we only search for the |
erikzhang
commented
May 20, 2022
src/neo/Persistence/DataCache.cs
Outdated
| @@ -95,6 +95,7 @@ public void Add(StorageKey key, StorageItem value) | |||
| { | |||
| TrackState.Deleted => TrackState.Changed, | |||
| TrackState.NotFound => TrackState.Added, | |||
| TrackState.Added => TrackState.Added, | |||
There was a problem hiding this comment.
It is incorrect. If the state is Added, we should throw. Because Add requires the key doesn't exist.
There was a problem hiding this comment.
But if someone use add twice? what's the sense of throw an exception, if it could be added?
shargon
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2720