SmartContract: add FindOptions.Backwards to iterate in reverse order #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the data scheme contracts may want to iterate over prefix in descending order. Fixes neo-project#2789.
AnnaShaleva
previously approved these changes
Sep 28, 2022
Closed
AnnaShaleva
previously approved these changes
Feb 3, 2023
erikzhang
reviewed
Feb 5, 2023
Co-authored-by: Erik Zhang <erik@neo.org>
|
@erikzhang @roman-khimov Let's move on. |
|
@shargon Mind to review this on? |
shargon
reviewed
Mar 17, 2023
shargon
previously approved these changes
Mar 21, 2023
AnnaShaleva
previously approved these changes
Apr 6, 2023
|
@Liaojinghui, @superboyiii, @erikzhang, could you review this PR, please? Let's move on with it, it's pretty useful. |
vncoelho
reviewed
Apr 9, 2023
| key2.Should().Be(items.ElementAt(2).Key); | ||
| value2.Should().Be(items.ElementAt(2).Value); | ||
| key1.Should().Be(items.ElementAt(3).Key); | ||
| value1.Should().Be(items.ElementAt(3).Value); |
There was a problem hiding this comment.
tests for the null cases length 0?
There was a problem hiding this comment.
Fixed and improved impl. a bit.
Jim8y
previously approved these changes
Apr 10, 2023
And add a test for null/empty cases.
roman-khimov
dismissed stale reviews from Jim8y, AnnaShaleva, and shargon
via
0c99b16
AnnaShaleva
approved these changes
Apr 11, 2023
Jim8y
approved these changes
Apr 11, 2023
shargon
approved these changes
Apr 12, 2023
vncoelho
approved these changes
Apr 12, 2023
roman-khimov
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Apr 12, 2023
core: add `Backwards` option to System.Storage.Find Port neo-project/neo#2819.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the data scheme contracts may want to iterate over prefix in descending order. Fixes #2789.