Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strictMode during deploy #2849

Merged
merged 5 commits into from
Apr 10, 2023
Merged

Use strictMode during deploy #2849

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5f46aa6
Check jumps
shargon Mar 12, 2023
2e76470
Use strict mode
shargon Mar 13, 2023
d3e90b9
Merge branch 'check-script' of https://github.com/neo-project/neo int…
shargon Mar 13, 2023
4eef3c8
Revert changes
shargon Mar 13, 2023
077c422
Merge branch 'master' into check-script
shargon Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions src/Neo/SmartContract/Helper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,69 @@ public static void Check(byte[] script, ContractAbi abi)
/// <remarks>Note: The <see cref="Script"/> passed to this method should be constructed with strict mode.</remarks>
public static void Check(this Script script, ContractAbi abi)
{
if (abi is null) throw new ArgumentNullException(nameof(abi));

Dictionary<int, Instruction> instructions = new();
for (int ip = 0; ip < script.Length;)
{
Instruction instruction = script.GetInstruction(ip);
instructions.Add(ip, instruction);
ip += instruction.Size;
}
shargon marked this conversation as resolved.
Show resolved Hide resolved
foreach (var (ip, instruction) in instructions)
{
switch (instruction.OpCode)
{
case OpCode.JMP:
case OpCode.JMPIF:
case OpCode.JMPIFNOT:
case OpCode.JMPEQ:
case OpCode.JMPNE:
case OpCode.JMPGT:
case OpCode.JMPGE:
case OpCode.JMPLT:
case OpCode.JMPLE:
case OpCode.CALL:
case OpCode.ENDTRY:
if (!instructions.ContainsKey(checked(ip + instruction.TokenI8)))
throw new IndexOutOfRangeException();
break;
case OpCode.PUSHA:
case OpCode.JMP_L:
case OpCode.JMPIF_L:
case OpCode.JMPIFNOT_L:
case OpCode.JMPEQ_L:
case OpCode.JMPNE_L:
case OpCode.JMPGT_L:
case OpCode.JMPGE_L:
case OpCode.JMPLT_L:
case OpCode.JMPLE_L:
case OpCode.CALL_L:
case OpCode.ENDTRY_L:
if (!instructions.ContainsKey(checked(ip + instruction.TokenI32)))
throw new IndexOutOfRangeException();
break;
case OpCode.TRY:
if (!instructions.ContainsKey(checked(ip + instruction.TokenI8)) ||
!instructions.ContainsKey(checked(ip + instruction.TokenI8_1)))
throw new IndexOutOfRangeException();
break;
case OpCode.TRY_L:
if (!instructions.ContainsKey(checked(ip + instruction.TokenI32)) ||
!instructions.ContainsKey(checked(ip + instruction.TokenI32_1)))
throw new IndexOutOfRangeException();
break;
case OpCode.NEWARRAY_T:
case OpCode.ISTYPE:
case OpCode.CONVERT:
StackItemType type = (StackItemType)instruction.TokenU8;
if (!Enum.IsDefined(typeof(StackItemType), type) ||
instruction.OpCode != OpCode.NEWARRAY_T && type == StackItemType.Any)
throw new IndexOutOfRangeException();
break;
}
}

foreach (ContractMethodDescriptor method in abi.Methods)
script.GetInstruction(method.Offset);
abi.GetMethod(string.Empty, 0); // Trigger the construction of ContractAbi.methodDictionary to check the uniqueness of the method names.
Expand Down