-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement economic adjustments for Conflicts attribute #2863
Implement economic adjustments for Conflicts attribute #2863
Commits on Mar 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 77d823c - Browse repository at this point
Copy the full SHA 77d823cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e42dd05 - Browse repository at this point
Copy the full SHA e42dd05View commit details -
Fix conflicting tx fees accounting
Fix the comment neo-project#2818 (comment).
Configuration menu - View commit details
-
Copy full SHA for 9c4bedf - Browse repository at this point
Copy the full SHA 9c4bedfView commit details
Commits on Apr 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4d54d60 - Browse repository at this point
Copy the full SHA 4d54d60View commit details
Commits on Apr 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0d6b7c2 - Browse repository at this point
Copy the full SHA 0d6b7c2View commit details
Commits on Apr 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2ed30f1 - Browse repository at this point
Copy the full SHA 2ed30f1View commit details
Commits on May 22, 2023
-
Make comments more clear and adjust variables naming
Fix Owen's feedback.
Configuration menu - View commit details
-
Copy full SHA for 1ac2913 - Browse repository at this point
Copy the full SHA 1ac2913View commit details -
Configuration menu - View commit details
-
Copy full SHA for 895026e - Browse repository at this point
Copy the full SHA 895026eView commit details
Commits on May 25, 2023
-
Fix Conflicts attribute verification
Consider the case when transaction B has the hash of transaction A in the Conflicts attribute and transaction B is on-chain. Let the transaction C has the hash of transaction A in the Conflicts attribute. Then transaction C still should be able to pass verification and should be accepted to the subsequent block, because transaction A isn't on chain and transaction A will never be accepted. Thanks to Owen for testing, this case is described at the neo-project#2818 (review). The expected behaviour in the described case is that TXID-D and TXID-E will be successfully accepted to the mempool and to chain, because the conflicting TXID-A is not on chain (and it's OK that the hash of TXID-A is on-chain as the conflicting hash).
Configuration menu - View commit details
-
Copy full SHA for 5798354 - Browse repository at this point
Copy the full SHA 5798354View commit details
Commits on May 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 658aafe - Browse repository at this point
Copy the full SHA 658aafeView commit details
Commits on May 29, 2023
-
Add one more testcase for conflicting transactions
Testcase provided by Vitor in neo-project#2818 (comment).
Configuration menu - View commit details
-
Copy full SHA for 1dbf965 - Browse repository at this point
Copy the full SHA 1dbf965View commit details
Commits on Jun 1, 2023
-
Implement economic adjustments for Conflicts attribute
Transaction that conflicts with mempooled transactions have to pay larger network fee than the sum of all conflicting transactions in the pool that have the same sender as the newcomer. Port the nspcc-dev/neo-go#3031.
Configuration menu - View commit details
-
Copy full SHA for dab46a8 - Browse repository at this point
Copy the full SHA dab46a8View commit details