Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement economic adjustments for Conflicts attribute #2863

Closed

Commits on Mar 12, 2023

  1. Configuration menu
    Copy the full SHA
    77d823c View commit details
    Browse the repository at this point in the history
  2. Update src/Neo/Ledger/MemoryPool.cs

    shargon authored and AnnaShaleva committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    e42dd05 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9c4bedf View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Reformat code and improve variables naming

    Fix Vitor's comments.
    AnnaShaleva committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    4d54d60 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Configuration menu
    Copy the full SHA
    0d6b7c2 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Configuration menu
    Copy the full SHA
    2ed30f1 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Make comments more clear and adjust variables naming

    Fix Owen's feedback.
    AnnaShaleva committed May 22, 2023
    Configuration menu
    Copy the full SHA
    1ac2913 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    895026e View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Fix Conflicts attribute verification

    Consider the case when transaction B has the hash of transaction A
    in the Conflicts attribute and transaction B is on-chain. Let the
    transaction C has the hash of transaction A in the Conflicts attribute.
    Then transaction C still should be able to pass verification and should
    be accepted to the subsequent block, because transaction A isn't on chain
    and transaction A will never be accepted.
    
    Thanks to Owen for testing, this case is described at the
    neo-project#2818 (review).
    The expected behaviour in the described case is that TXID-D and TXID-E will
    be successfully accepted to the mempool and to chain, because the conflicting
    TXID-A is not on chain (and it's OK that the hash of TXID-A is on-chain as
    the conflicting hash).
    AnnaShaleva committed May 25, 2023
    Configuration menu
    Copy the full SHA
    5798354 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Configuration menu
    Copy the full SHA
    658aafe View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. Add one more testcase for conflicting transactions

    Testcase provided by Vitor in neo-project#2818 (comment).
    AnnaShaleva committed May 29, 2023
    Configuration menu
    Copy the full SHA
    1dbf965 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Implement economic adjustments for Conflicts attribute

    Transaction that conflicts with mempooled transactions have to pay
    larger network fee than the sum of all conflicting transactions in
    the pool that have the same sender as the newcomer.
    
    Port the nspcc-dev/neo-go#3031.
    AnnaShaleva committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    dab46a8 View commit details
    Browse the repository at this point in the history