Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add memory pool capacity check and transaction expiration check #2865

Closed
wants to merge 2 commits into from
Closed

add memory pool capacity check and transaction expiration check #2865

wants to merge 2 commits into from

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Jun 3, 2023

Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Liaojinghui,

In this line of thinking, a good direction for neo-core code could be:

  • Create a first PR that is focused on a design for NEO C# Core to handle "alternate mempool"
  • The pool can be "next-block-or-never inclusion" (such as the one you proposed here)
  • The pool can be any other strategy with fees, among others
  • These pools can also be added as plugins
  • CNs could handle a list of mempool and sort them first, before picking txs. Thus, there could be a parameter that sets priorities of pools (committee role)

I think it is worth checking Ethereum EIP 4337 which also has "alternate mempool" concepts for a nice feature focused on account abstraction.

@Jim8y
Copy link
Contributor Author

Jim8y commented Jun 3, 2023

@vncoelho Thank you Vitor for informing me that EIP, will learn and try to optimize this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants