-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hardfork for StrictMode #2881
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superboyiii
approved these changes
Aug 1, 2023
@roman-khimov @AnnaShaleva @shargon Could you review? |
AnnaShaleva
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this fixes the problem.
@vncoelho Bro, need your review as well. |
roman-khimov
reviewed
Aug 1, 2023
vncoelho
approved these changes
Aug 1, 2023
shargon
approved these changes
Aug 1, 2023
@Ashuaidehao could you acept the license? |
@dotnet-policy-service agree |
Merge? |
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Aug 3, 2023
1 task
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Aug 3, 2023
Follow the neo-project/neo#2881. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@shargon @vncoelho @roman-khimov Merge? |
roman-khimov
approved these changes
Aug 7, 2023
AnnaShaleva
approved these changes
Aug 7, 2023
shargon
added a commit
that referenced
this pull request
Aug 9, 2023
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Aug 9, 2023
Follow the neo-project/neo#2881. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Aug 9, 2023
Follow the neo-project/neo#2881. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Aug 9, 2023
Follow the neo-project/neo#2881. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
shargon
added a commit
that referenced
this pull request
Aug 18, 2023
* Check ABI for notifications * Patch checkabi (#2884) * Remove extra space (#2878) * Add Hardfork for StrictMode (#2881) * init * rename * hardfork * Update ApplicationEngine.Runtime.cs --------- Co-authored-by: Shargon <shargon@gmail.com> * Check UTF8 string * Cleaner way * Fix Buffer * Update src/Neo/SmartContract/ApplicationEngine.Runtime.cs Co-authored-by: Anna Shaleva <anna@nspcc.ru> --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com> Co-authored-by: Shine Li <bfshm@qq.com> Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Anna Shaleva <anna@nspcc.ru>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2873