throw exception on null scriptcontainer #2956
Conversation
There was a problem hiding this comment.
Like this you always will check if it's null, with the previous version you only check if it's null when is not a transaction, so we have one condition less and it doesn't affect the tps.
since it will false or exception, there is no need to perform any check or execution at all, a waste of CPU time.
I prefer to waste cpu in neo-express than in mainnet
Well, its exactly wasting mainnet CPU time. Fair enough, close if you dont like. |
| UInt160 hash = hashOrPubkey.Length switch | ||
| { | ||
| 20 => new UInt160(hashOrPubkey), | ||
| 33 => Contract.CreateSignatureRedeemScript(ECPoint.DecodePoint(hashOrPubkey, ECCurve.Secp256r1)).ToScriptHash(), | ||
| _ => throw new ArgumentException(null, nameof(hashOrPubkey)) | ||
| _ => throw new ArgumentException("Invalid hashOrPubKey", nameof(hashOrPubkey)) |
There was a problem hiding this comment.
will crate another pr, this one is mainly about the exception.
Hi @shargon, I am sorry if this makes you think it is a duplicate pr, i just think #2953 might be better to be solved in this way.
since it will
falseorexception, there is no need to perform any check or execution at all, a waste of CPU time.it should be an exception instead of a
false, the same logic for checking thehashOrPubkey, it should be consistent.Thus, I do the null check in the firstline of the
CheckWitnessmethod instead of inCheckWitnessInternal, since this check will be done anyway if its null.