[Neo Fix] fix the store crash issue #3124
Conversation
|
Updated @shargon |
| if (_neoSystem != null) return; | ||
| if (NeoSystem != null) return; |
There was a problem hiding this comment.
@shargon why revert these back to NeoSystem? this code is useless here, you must use _neoSystem.
| { | ||
| return StoreFactory.GetStore(store.GetType().Name, path); | ||
| } | ||
|
|
There was a problem hiding this comment.
why did you remove this? This will break plugins
There was a problem hiding this comment.
#3126 now check it here, wont mark it as absolete, still using it. My bad. Need some rest to work more carefully.
There was a problem hiding this comment.
Its an public API should be marked as obsolete. If you want to remove it.
There was a problem hiding this comment.
We can use Factory in modules, it's not a problem, currently only neo use neo library.
There was a problem hiding this comment.
We can use Factory in modules, it's not a problem, currently only neo use neo library.
No, I have searched, neoxp also use it, not sure any other tools also using it. @cschuchardt88 is right, its public, cant be changed easily.
* 'nullable' of github.com:Jim8y/neo: [Neo Fix] fix the store crash issue (neo-project#3124) [Neo VM: FIX] the GetString() methods of bytestring requires strictUTF8 (neo-project#3110)
Description
This pr focus on fixing the issue mentioned in #3123 that the default value of Factory and the initialization order of NeoSystem and StoreFactory caused the null reference.
Fixes # (issue) #3123
Type of change
How Has This Been Tested?
Run existing tests.
Test Configuration:
Checklist: