Fix coverage

[shargon]

The coverage is sometimes random, this pr aims to fix it

[vncoelho]

this will be good if fixed

[vncoelho]

Option path-to-lcov is now deprecated, use file instead.

[vncoelho]

maybe version v2.2.3

[vncoelho]

"You can also skip using the file option and coveralls will try to find all supported coverage files and combine their data."
"If coveralls fails to determine your coverage report format, use explicit format option to specify it. See supported values."

[shargon]

I think that now it's fixed!

[vncoelho]

I think it is fixed, it was good to check their release info.

Maybe we can also leave the file config empty and delete it.

[shargon]

It only take cryptography https://coveralls.io/builds/65868879

not ready

[vncoelho]

I just tried something to be sure, let's see the result.

Recently I got some problems on devcontainer if these commands were not executed before

[vncoelho]

Since the last command is just used for ubuntu

maybe remove the rest of the parameter for the other matrix.os

    - name: Test
      run: |
        find tests -name *.csproj | xargs -I % dotnet add % package coverlet.msbuild
        dotnet test /p:CollectCoverage=true /p:CoverletOutputFormat=lcov /p:CoverletOutput=${GITHUB_WORKSPACE}/coverage/lcov /p:MergeWith="./coverage/lcov.net7.0.info"
    - name: Coveralls
      if: matrix.os == 'ubuntu-latest'
      uses: coverallsapp/github-action@v2.2.3
      with:
        github-token: ${{ secrets.GITHUB_TOKEN }}
        file: ./coverage/lcov.net7.0.info
        ```

[vncoelho]

why we need merge? Which additional reports should be added?

[shargon]

Please @vncoelho wait for my wait for review

[shargon]

The doc said that it's required to merge the test one by one, and convert to the desired format in the last one:

https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/Examples/MSBuild/MergeWith/HowTo.md

[vncoelho]

The doc said that it's required to merge the test one by one, and convert to the desired format in the last one:

https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/Examples/MSBuild/MergeWith/HowTo.md

I saw this as well later

[vncoelho]

I think you should use the default as well without specifying, it will be json

/p:CoverletOutput=../CoverageResults/ /p:MergeWith="../CoverageResults/coverage.json"

[shargon]

It works now :)

[vncoelho]

perfect, I think you can change to

    - name: Test for Win and Mac
      if: matrix.os == 'windows-latest' || matrix.os == 'macos-latest'   
      run: |
        dotnet test     
    - name: Test for Coveralls Only
      if: matrix.os == 'ubuntu-latest'  

[shargon]

This should also be done in modules and devpack