Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Neo CLI Optimization] fix exception message #3314

Merged
merged 10 commits into from
Jun 14, 2024
Merged

[Neo CLI Optimization] fix exception message #3314

merged 10 commits into from
Jun 14, 2024

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Jun 9, 2024

Description

PR 38cc0e9 fiexd the dll missing problem on windows server, but its checking and error message is too simple and shows installing exe on macos.

Fixes # #3199

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

cschuchardt88
cschuchardt88 previously requested changes Jun 9, 2024
View reviewed changes
src/Neo.CLI/CLI/MainService.cs Outdated Show resolved Hide resolved
@Jim8y Jim8y requested a review from a team June 10, 2024 11:19
vncoelho
vncoelho reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Jim8y Jim8y requested a review from a team June 10, 2024 13:42
@NGDAdmin NGDAdmin merged commit 4c1194f into neo-project:master Jun 14, 2024
6 checks passed
Jim8y added a commit to Jim8y/neo that referenced this pull request Jun 14, 2024
@Jim8y
Merge branch 'master' into mock-rpcserver-test
9b238ec 
* master:
  Fixed pathing and Property (neo-project#3306)
  [Neo CLI New Feature] Allow custom plugins (neo-project#3295)
  Return expect to verify neo-cli (neo-project#3318)
  [Neo CLI Optimization] fix exception message (neo-project#3314)
  fix plugin download url (neo-project#3329)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov left review comments

@vncoelho vncoelho vncoelho left review comments

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

@cschuchardt88 cschuchardt88 cschuchardt88 approved these changes

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
Ready to Merge Waiting for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Jim8y @shargon @cschuchardt88 @vncoelho @roman-khimov @AnnaShaleva @NGDAdmin