-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Neo VM Style] Add comments and document to reference counter #3331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should wait for #3328 before merge it, because of conflicts
should be fine, its just comments. |
if (!item.ObjectReferences.TryGetValue(parent, out var pEntry)) | ||
{ | ||
pEntry = new(parent); | ||
pEntry = new StackItem.ObjectReferenceEntry(parent); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert this change from here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problems like this are very minor, not worth a pr to fix, but if we don't fix it, it will always be this unclear syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix in another PR, it is better.
Let just comments here
Even the underscore could be moved to another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @Jim8y
There is just a minor change to be reverted I think
Description
Neo VM reference counter is a very important component, but it is very complex and is hard to understand. Making it actually UNMAINTAINABLE. Thus having this pr that adds detailed explaination and comments to all its related code.
Fixes # None
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: