[Neo Core Bug] fix compound type reference issue #3334

Jim8y · 2024-06-13T03:05:46Z

Description

This one serves as similier purpose of #3325. This pr addresses the issue of compound type can add items that contain subitems not added to the referenc counter.

This pr ensures that all items be correctly calculated to the reference counter.

Fixes # (issue)

Type of change

Optimization (the change is only an optimization)
Style (the change is only a code style for better maintenance or standard purpose)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

TestInvalidReferenceStackItem

Test Configuration:

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

tests/Neo.VM.Tests/UT_ReferenceCounter.cs

vncoelho

I am in agreement with this solution, this looks like to be fully compatible.

shargon

Couls you explain this solution?

Jim8y · 2024-06-15T04:38:34Z

Couls you explain this solution?

Deepcopy can rebuild the reference relationship, add those not calculated items into the reference counter. So, I will check every single compound type that is added to the array, if that compound has no referecencounter, means its not calculated with reference counter, so i assign it the reference counter and deepcopy it, such that we not only add the compound itself, but also add every single subitem in that compound type.

For instance:

arr = Array(referencecounter);

arr2 = Array(){1,2,3,4,5,6,7};

arr.add(arr2); \ previously this will only add one reference counter, all subitems in the arr2 will not be calculated.

But with this pr, arr will know arr2 is a compound type and its referencecounter is null, so it will not add arr2, but add a deepcopied arr2, which has all its subitems calculated with referencecounter.

shargon · 2024-06-18T07:41:50Z

But I think that the bug can be replicated without decopy 🤔

Jim8y · 2024-06-18T07:52:43Z

But I think that the bug can be replicated without decopy 🤔

There will always be another solution, just depends on how you want it to be solved. The problem is does this pr fix the issue.

roman-khimov · 2024-06-27T14:32:32Z

src/Neo.VM/Types/Array.cs

+                if (value is CompoundType { ReferenceCounter: null } compoundType)
+                {
+                    compoundType.ReferenceCounter = ReferenceCounter;
+                    ReferenceCounter?.AddReference(value.DeepCopy(), this);


I fear this can explode, imagine deeply nested structures that you would try to deep-copy just to count references, what's gonna happen to execution time with this code?

if deepcopy can go explode, then i think it should be a problem of deepcopy, isnt it?

i think it should be a problem of deepcopy

It will be a problem of the whole node.

Think of things like #2723. DeepCopy will do its job, no doubt about it, but it will affect the cost/time balance of some opcodes. Like PICKITEM is affected by this line IIUC and it's cheap, it's supposed to be cheap.

i think it should be a problem of deepcopy

It will be a problem of the whole node.

I mean if deepcopy can explode, it means deepcopy itself is problematic, and should be fixing deepcopy, instead of here. And @roman-khimov's concern is reasonable, but if balance is a concern here, it should be a concern everywhere and everytime we make any change to the core. We dont have benchmark for them, has being working like this. But I will add a benchmark specifically for this one.

* master: (27 commits) Revert "Plugin unhandled exception (neo-project#3349)" (neo-project#3366) `[Move]` Part-2 Classes into Different Library - `Neo.IO` (neo-project#3388) [Neo Core Store] Rename various snapshots. (neo-project#3406) [Neo Core Storage] Implicit methods and tests (neo-project#3403) [Neo Core MemoryStore] MemoryStore Unit Tests. (neo-project#3404) Fixed Publish Step (neo-project#3411) Fix release compilation (neo-project#3417) [Neo Plugin UT] Rpcserver unit test on node (neo-project#3353) Improve code coverage (neo-project#3354) `[Add]` Debug Output to `Expect` (neo-project#3407) [Neo Plugin Store] Unit test (neo-project#3399) Bump System.Text.Json from 8.0.3 to 8.0.4 in /src/Neo.Json (neo-project#3416) `[Typo]` Unit Tests - UT_ProtocolSettings.CreateHKSettings (neo-project#3383) `[Fix]` Test Problems (neo-project#3398) Part-1 `Neo.IO` - move (neo-project#3387) Fixed Props Pathing for `dotnet pack` with `nuget` (neo-project#3379) `[neo-cli]` Error Message and Warning - LevelDb (neo-project#3380) Fix crash when comparing ContractPermissionDescriptor (neo-project#3396) `DeprecatedIn` for events (neo-project#3362) Fix download tips (neo-project#3395) ...

Jim8y · 2024-07-23T11:44:21Z

BenchmarkDotNet v0.13.12, Windows 11 (10.0.22631.3880/23H2/2023Update/SunValley3)
Intel Core i9-14900HX, 1 CPU, 32 logical and 24 physical cores
.NET SDK 8.0.205
[Host] : .NET 8.0.5 (8.0.524.21615), X64 RyuJIT AVX2
DefaultJob : .NET 8.0.5 (8.0.524.21615), X64 RyuJIT AVX2

Method	Params	Mean	Error	StdDev	Median
BenchNestedArrayDeepCopy	(1, 1)	342.7 ns	7.33 ns	21.50 ns	340.5 ns
BenchNestedArrayDeepCopyWithReferenceCounter	(1, 1)	288.8 ns	5.49 ns	12.28 ns	285.9 ns
BenchNestedTestArrayDeepCopy	(1, 1)	243.8 ns	2.89 ns	2.70 ns	242.8 ns
BenchNestedTestArrayDeepCopyWithReferenceCounter	(1, 1)	286.3 ns	2.35 ns	2.20 ns	285.8 ns
BenchNestedArrayDeepCopy	(1, 2)	498.8 ns	5.65 ns	5.29 ns	496.3 ns
BenchNestedArrayDeepCopyWithReferenceCounter	(1, 2)	415.6 ns	3.78 ns	3.54 ns	415.0 ns
BenchNestedTestArrayDeepCopy	(1, 2)	363.9 ns	2.83 ns	2.65 ns	364.1 ns
BenchNestedTestArrayDeepCopyWithReferenceCounter	(1, 2)	413.0 ns	2.89 ns	2.56 ns	412.5 ns
BenchNestedArrayDeepCopy	(1, 4)	942.6 ns	7.98 ns	7.47 ns	943.2 ns
BenchNestedArrayDeepCopyWithReferenceCounter	(1, 4)	785.1 ns	5.94 ns	5.27 ns	783.9 ns
BenchNestedTestArrayDeepCopy	(1, 4)	662.3 ns	4.96 ns	4.64 ns	661.1 ns
BenchNestedTestArrayDeepCopyWithReferenceCounter	(1, 4)	785.8 ns	7.59 ns	7.10 ns	783.8 ns
BenchNestedArrayDeepCopy	(1, 8)	1,938.0 ns	22.97 ns	21.49 ns	1,935.1 ns
BenchNestedArrayDeepCopyWithReferenceCounter	(1, 8)	1,553.8 ns	14.70 ns	13.75 ns	1,550.5 ns
BenchNestedTestArrayDeepCopy	(1, 8)	1,317.0 ns	14.75 ns	13.08 ns	1,317.5 ns
BenchNestedTestArrayDeepCopyWithReferenceCounter	(1, 8)	1,540.5 ns	16.88 ns	14.97 ns	1,538.9 ns
BenchNestedArrayDeepCopy	(2, 1)	519.1 ns	6.16 ns	5.77 ns	517.7 ns
BenchNestedArrayDeepCopyWithReferenceCounter	(2, 1)	426.0 ns	2.52 ns	2.35 ns	424.7 ns
BenchNestedTestArrayDeepCopy	(2, 1)	299.2 ns	2.41 ns	2.01 ns	298.7 ns
BenchNestedTestArrayDeepCopyWithReferenceCounter	(2, 1)	433.8 ns	5.08 ns	4.75 ns	432.7 ns
BenchNestedArrayDeepCopy	(2, 2)	1,364.1 ns	12.05 ns	11.27 ns	1,359.2 ns
BenchNestedArrayDeepCopyWithReferenceCounter	(2, 2)	1,120.2 ns	7.79 ns	6.08 ns	1,118.4 ns
BenchNestedTestArrayDeepCopy	(2, 2)	601.1 ns	6.54 ns	5.80 ns	599.2 ns
BenchNestedTestArrayDeepCopyWithReferenceCounter	(2, 2)	1,105.8 ns	12.09 ns	11.31 ns	1,104.7 ns
BenchNestedArrayDeepCopy	(2, 4)	4,339.6 ns	37.40 ns	33.16 ns	4,337.2 ns
BenchNestedArrayDeepCopyWithReferenceCounter	(2, 4)	3,559.7 ns	23.42 ns	21.90 ns	3,561.1 ns
BenchNestedTestArrayDeepCopy	(2, 4)	1,578.1 ns	13.08 ns	12.23 ns	1,581.3 ns
BenchNestedTestArrayDeepCopyWithReferenceCounter	(2, 4)	3,629.1 ns	60.46 ns	71.98 ns	3,611.7 ns
BenchNestedArrayDeepCopy	(2, 8)	15,161.5 ns	284.68 ns	279.60 ns	15,134.7 ns
BenchNestedArrayDeepCopyWithReferenceCounter	(2, 8)	12,655.0 ns	251.70 ns	352.85 ns	12,746.1 ns
BenchNestedTestArrayDeepCopy	(2, 8)	4,876.1 ns	96.47 ns	176.39 ns	4,817.0 ns
BenchNestedTestArrayDeepCopyWithReferenceCounter	(2, 8)	11,934.8 ns	228.58 ns	224.50 ns	11,924.4 ns
BenchNestedArrayDeepCopy	(4, 1)	1,002.1 ns	17.35 ns	16.23 ns	1,005.1 ns
BenchNestedArrayDeepCopyWithReferenceCounter	(4, 1)	837.7 ns	14.06 ns	13.15 ns	833.4 ns
BenchNestedTestArrayDeepCopy	(4, 1)	433.5 ns	5.17 ns	4.04 ns	432.4 ns
BenchNestedTestArrayDeepCopyWithReferenceCounter	(4, 1)	832.6 ns	6.60 ns	6.17 ns	832.1 ns
BenchNestedArrayDeepCopy	(4, 2)	6,382.8 ns	52.77 ns	44.06 ns	6,369.0 ns
BenchNestedArrayDeepCopyWithReferenceCounter	(4, 2)	5,198.7 ns	103.92 ns	111.19 ns	5,212.9 ns
BenchNestedTestArrayDeepCopy	(4, 2)	1,969.3 ns	33.25 ns	31.10 ns	1,972.6 ns
BenchNestedTestArrayDeepCopyWithReferenceCounter	(4, 2)	5,128.0 ns	52.40 ns	49.01 ns	5,097.1 ns
BenchNestedArrayDeepCopy	(4, 4)	77,014.5 ns	1,536.10 ns	4,100.16 ns	75,942.0 ns
BenchNestedArrayDeepCopyWithReferenceCounter	(4, 4)	60,333.2 ns	1,170.70 ns	1,437.73 ns	60,137.2 ns
BenchNestedTestArrayDeepCopy	(4, 4)	17,854.7 ns	322.02 ns	285.46 ns	17,743.9 ns
BenchNestedTestArrayDeepCopyWithReferenceCounter	(4, 4)	58,003.2 ns	981.22 ns	819.36 ns	57,759.1 ns
BenchNestedArrayDeepCopy	(4, 8)	2,199,376.3 ns	41,871.98 ns	67,615.45 ns	2,215,854.7 ns
BenchNestedArrayDeepCopyWithReferenceCounter	(4, 8)	1,695,943.3 ns	32,124.96 ns	62,657.26 ns	1,694,366.6 ns
BenchNestedTestArrayDeepCopy	(4, 8)	438,148.5 ns	8,662.74 ns	15,840.31 ns	437,996.0 ns
BenchNestedTestArrayDeepCopyWithReferenceCounter	(4, 8)	1,609,254.3 ns	30,799.54 ns	32,955.16 ns	1,602,670.7 ns
BenchNestedArrayDeepCopy	(8, 1)	1,927.7 ns	38.27 ns	78.18 ns	1,913.7 ns
BenchNestedArrayDeepCopyWithReferenceCounter	(8, 1)	1,583.2 ns	11.60 ns	10.85 ns	1,582.5 ns
BenchNestedTestArrayDeepCopy	(8, 1)	683.8 ns	5.48 ns	5.13 ns	682.7 ns
BenchNestedTestArrayDeepCopyWithReferenceCounter	(8, 1)	1,589.8 ns	13.69 ns	12.81 ns	1,594.5 ns
BenchNestedArrayDeepCopy	(8, 2)	118,258.4 ns	982.00 ns	918.56 ns	118,253.0 ns
BenchNestedArrayDeepCopyWithReferenceCounter	(8, 2)	94,085.7 ns	930.96 ns	870.82 ns	94,000.1 ns
BenchNestedTestArrayDeepCopy	(8, 2)	32,212.5 ns	611.43 ns	600.51 ns	31,878.1 ns
BenchNestedTestArrayDeepCopyWithReferenceCounter	(8, 2)	93,682.6 ns	900.93 ns	842.73 ns	93,619.1 ns
BenchNestedArrayDeepCopy	(8, 4)	169,669,360.4 ns	3,355,690.79 ns	9,014,845.40 ns	171,844,412.5 ns
BenchNestedArrayDeepCopyWithReferenceCounter	(8, 4)	122,859,534.5 ns	2,418,377.86 ns	4,422,140.67 ns	123,617,262.5 ns
BenchNestedTestArrayDeepCopy	(8, 4)	33,864,065.4 ns	655,980.72 ns	940,787.95 ns	33,728,600.0 ns
BenchNestedTestArrayDeepCopyWithReferenceCounter	(8, 4)	122,422,048.6 ns	2,429,404.01 ns	6,004,884.81 ns	123,007,820.0 ns
BenchNestedArrayDeepCopy	(8, 8)	40,992,899,973.3 ns	438,805,673.14 ns	410,459,098.91 ns	40,981,608,100.0 ns
BenchNestedArrayDeepCopyWithReferenceCounter	(8, 8)	32,127,834,113.3 ns	508,499,401.55 ns	475,650,655.71 ns	32,224,817,100.0 ns
BenchNestedTestArrayDeepCopy	(8, 8)	10,234,584,550.0 ns	202,267,927.80 ns	348,902,237.42 ns	10,279,612,600.0 ns
BenchNestedTestArrayDeepCopyWithReferenceCounter	(8, 8)	33,541,280,817.4 ns	643,685,928.91 ns	814,056,600.31 ns	33,609,456,200.0 ns
BenchNestedArrayDeepCopy	(16, 1)	3,552.6 ns	69.79 ns	163.13 ns	3,516.8 ns
BenchNestedArrayDeepCopyWithReferenceCounter	(16, 1)	2,912.8 ns	53.35 ns	134.83 ns	2,852.2 ns
BenchNestedTestArrayDeepCopy	(16, 1)	1,240.0 ns	32.92 ns	93.91 ns	1,213.0 ns
BenchNestedTestArrayDeepCopyWithReferenceCounter	(16, 1)	3,517.9 ns	78.82 ns	232.41 ns	3,441.4 ns
BenchNestedArrayDeepCopy	(16, 2)	257,862,647.2 ns	5,155,211.45 ns	8,613,200.24 ns	257,611,450.0 ns
BenchNestedArrayDeepCopyWithReferenceCounter	(16, 2)	187,807,686.8 ns	3,729,102.21 ns	8,185,469.76 ns	188,697,883.3 ns
BenchNestedTestArrayDeepCopy	(16, 2)	51,730,038.3 ns	1,021,419.37 ns	1,678,221.31 ns	51,624,790.0 ns
BenchNestedTestArrayDeepCopyWithReferenceCounter	(16, 2)	186,950,476.6 ns	3,722,915.31 ns	8,628,422.34 ns	186,145,150.0 ns

Jim8y · 2024-07-23T14:24:31Z

Method	Params	Mean	Error	StdDev
BenchNestedArrayDeepCopy	(4, 6)	413.90 us	8.113 us	11.635 us
BenchNestedArrayDeepCopyWithReferenceCounter	(4, 6)	313.05 us	6.172 us	12.883 us
BenchNestedTestArrayDeepCopy	(4, 6)	92.82 us	0.966 us	0.903 us
BenchNestedTestArrayDeepCopyWithReferenceCounter	(4, 6)	302.10 us	4.965 us	4.644 us

Jim8y · 2024-07-23T14:45:01Z

@roman-khimov @shargon @cschuchardt88 @vncoelho benchmark shows that rebuild the reference reelationship will incur 4 times overhead....thus i suggest to throw exception directly. User will not be able to construst an compoundtype without referencecounter from the contract, thus the only plaace that can exploit it by our misimplementing.....

benchmarks/Neo.Benchmarks/Program.cs

benchmarks/Neo.VM.Benchmarks/Benchmarks.Types.cs

src/Neo.VM/EvaluationStack.cs

src/Neo.VM/Types/Map.cs

src/Neo.VM/Types/CompoundType.cs

shargon

LGTM but with conflicts

src/Neo.VM/Types/Map.cs

Co-authored-by: Shargon <shargon@gmail.com>

* master: [Neo Core Add] add char support (neo-project#3441) [rpc] Extend `getversion` RPC response with additional protocol settings (neo-project#3443) update benchmark system (neo-project#3442) [`Optimization`] Parsing Smart Contract Script Analysis (neo-project#3420) `[Move]` Part-3 Classes into Different Library - `Neo.Extensions` (neo-project#3400) # Conflicts: # benchmarks/Neo.Benchmarks/Benchmarks.POC.cs # benchmarks/Neo.VM.Benchmarks/Benchmarks.POC.cs # benchmarks/Neo.VM.Benchmarks/Program.cs

@shargon

* Remove comments in `nuget.yml` (#3359) * Fixed Typo in `nuget.yml` * reverted for path * Fix: `MemPool` null checks (#3367) * Fix null error * Add [MaybeNullWhen(false)] * Update MemoryPool.cs * plugins: remove expressions that are always true (#3393) * this expression is always true * Improve --------- Co-authored-by: Shargon <shargon@gmail.com> * [**Part-1] Add `github` Release Workflow (#3308) * Added `release.yml` * Fixed `release.yml` * Remove `VersionPrefix` * Added macos leveldb * Fixed * Remove comments on the command-line * Fixed `CodeSign` `neo-cli` * Added steps for `codesign` in `release.yml` --------- Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * cli: Fix `plugins` command (#3394) * Fix plugin list * Update src/Neo.CLI/CLI/MainService.Plugins.cs --------- Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Added blame logging for `dotnet test` (#3384) Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Shargon <shargon@gmail.com> * Fix download tips (#3395) * Added `release.yml` * Fixed `release.yml` * Remove `VersionPrefix` * Added macos leveldb * Fixed * Remove comments on the command-line * Fixed `CodeSign` `neo-cli` * Added steps for `codesign` in `release.yml` * Add downloading plugin tips * Change to ConsoleHelper * Move before first download --------- Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> Co-authored-by: Shargon <shargon@gmail.com> * `DeprecatedIn` for events (#3362) * DeprecatedIn for events * Added UT * Remove using --------- Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Fix crash when comparing ContractPermissionDescriptor (#3396) * Update ContractPermissionDescriptor.cs * Add UT --------- Co-authored-by: Fernando Diaz Toledano <shargon@gmail.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * `[neo-cli]` Error Message and Warning - LevelDb (#3380) * Fixed warnings and error message for `libleveldb` missing * Update src/Neo.CLI/CLI/MainService.cs Co-authored-by: lingyido <lingyido@gmail.com> --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: lingyido <lingyido@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Fixed Props Pathing for `dotnet pack` with `nuget` (#3379) Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Part-1 `Neo.IO` - move (#3387) Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * `[Fix]` Test Problems (#3398) * Fix Test crashes * disable Build servers * Fixed Building problem with tests * Fixed command line * Removed disable build servers --------- Co-authored-by: Shargon <shargon@gmail.com> * `[Typo]` Unit Tests - UT_ProtocolSettings.CreateHKSettings (#3383) * Typeo with `CreateHKSettings` * fix ut --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Bump System.Text.Json from 8.0.3 to 8.0.4 in /src/Neo.Json (#3416) Bumps System.Text.Json from 8.0.3 to 8.0.4. --- updated-dependencies: - dependency-name: System.Text.Json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Neo Plugin Store] Unit test (#3399) * test * fix snapshot issue and add tests * fix test * apply old snapshot * remove duplicate * Remove method --------- Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> Co-authored-by: Shargon <shargon@gmail.com> * `[Add]` Debug Output to `Expect` (#3407) * Added Debug to Expect * Update file paths --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Improve code coverage (#3354) * update * remove binary file * Add UT and fixed bug * Add UT and fixed bug * Add UT * Add UT * Add UT * Update src/Neo/SmartContract/Manifest/ContractManifest.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * Update src/Neo/SmartContract/Manifest/ContractManifest.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * Update src/Neo/SmartContract/Manifest/ContractManifest.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * Update Base58.cs * Update UT_Cryptography_Helper.cs * Update Base58.cs * update * Update ContractManifest.cs * Revert change that affect a syscall * Revert try * Remove using * Update src/Neo/SmartContract/Manifest/ContractManifest.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * Update src/Neo/SmartContract/Manifest/ContractAbi.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * Update src/Neo/SmartContract/Manifest/ContractManifest.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> --------- Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Fernando Diaz Toledano <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * [Neo Plugin UT] Rpcserver unit test on node (#3353) * try mock * not use mock * test * fix test * use neo testutils * complete rpcserver blockchain tests. * revert change to ByteArrayComparer * revert cache change * add more detail to comments * add more exception test cases * fix warning * Apply suggestions from code review * update TODO mark * add node rpc tests * fix build error * set the mempool to 5. * remove memory pool test. * fix tests * fix test issue * Update tests/Neo.UnitTests/TestUtils.Transaction.cs --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Fix release compilation (#3417) * Fix release * typo * Fixed Publish Step (#3411) Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * [Neo Core MemoryStore] MemoryStore Unit Tests. (#3404) * test * fix snapshot issue and add tests * fix test * apply old snapshot * memory snapshot tests * memory test * add more tests * make it more clear * revert storetest --------- Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> Co-authored-by: Shargon <shargon@gmail.com> * [Neo Core Storage] Implicit methods and tests (#3403) * implicit methods and tests * udpate --------- Co-authored-by: Shargon <shargon@gmail.com> * [Neo Core Store] Rename various snapshots. (#3406) * rename snapshot * Remove warning --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * `[Move]` Part-2 Classes into Different Library - `Neo.IO` (#3388) * Part-1 `Neo.IO` - move * Part-2 * Added `BigInteger` to `Neo.Extensions` * Found more `BigInteger` * Added Tests * Update tests/Neo.Extensions.Tests/UT_BigIntegerExtensions.cs --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Jimmy <jinghui@wayne.edu> * Revert "Plugin unhandled exception (#3349)" (#3366) This reverts commit b2f060f. Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * fix obsolete warning (#3428) * Neo.CLI: update MaxTraceableBlocks setting for NeoFS networks (#3424) We don't need long tails for NeoFS networks, 3 days is enough for now. It's checked that this change does not affect the network states. Port nspcc-dev/neo-go#3518. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Upgrade `nuget` packages (#3421) Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * [Neo Core Fix]use strong randomness (#3432) * use strong randomness * Update src/Plugins/DBFTPlugin/Consensus/ConsensusContext.MakePayload.cs --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Fixed warning (#3430) Co-authored-by: Shargon <shargon@gmail.com> * [Neo Core UT] Fix ut and style (#3413) * fix ut and style * clean * update test * Update tests/Neo.UnitTests/IO/Caching/UT_DataCache.cs Co-authored-by: Hecate2 <hecate2@qq.com> --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Hecate2 <hecate2@qq.com> Co-authored-by: Hecate2 <2474101468@qq.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * [**Added**] Build `neo-cli` Docker Image (#3355) * Added `devcontrainer` test for `neo-cli` * Basic contrainer setup * Updated version of `checkout` action job's step. * Changed to `neo-cli` * Update `dockerfile` * Updated `PostCreateCommand` * Changed to `bookworm-slim` * Reverted to `Jammy` * Added `sudo` command for `PostCreateCommand` * Added permissions * Removed `screen` command * Added to `bin` and `PostCreateCommand` * Changed `devcontainer` files * Reverted builds * Added `neo` repo to devcontainer * Changed to docker-image for github registry * Fixed Bugs in `docker` support for `neo-cli` image * Added type `container` * Revert `.devcontainer` folder * format * Changed workflow to `docker` for `pkgs-delete.yml` since we use `v4` * Deleted `Dockerfile` from `src\Neo.CLI` * Revert "Deleted `Dockerfile` from `src\Neo.CLI`" This reverts commit b877de0. --------- Co-authored-by: Jimmy <jinghui@wayne.edu> * [Neo Core Doc]create a docs folder and move existing doc to it. (#3435) * create a docs folder and move existing doc to it. * move neocli config md * [**Part-1**] Added `ApplicationLogs` Unit Tests (#3346) * Added ApplicationLogs Tests * Fixed pathing and naming * Merged `Part-2` * Fixed Test for `Test_Put_Get_NotifyState_Storage` --------- Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Jimmy <jinghui@wayne.edu> * add unit tests for json (#2993) * add unit tests for json * fix ut * add ut cases for JString. * add invalid jpath tests * behavior of jboolean is kinda weird. i have: Assert.AreEqual failed. Expected:<true>. Actual:<true>. * fix test error * add more test --------- Co-authored-by: Shargon <shargon@gmail.com> * [Neo Core VM] complete opcode comments (#3437) * complete opcode comments * Apply suggestions from code review * Update src/Neo.VM/OpCode.cs --------- Co-authored-by: Shargon <shargon@gmail.com> * [Neo Core] Obsolete applicationengine snapshot (#3436) * Obsolete applicationengine snapshot * fix UT names * fix executioncontextstate --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * [Neo Plugin RpcServer UT]Plugin rpcserver wallet UTs (#3433) * wallet * fix util * add comments and fix ut * Update tests/Neo.Plugins.RpcServer.Tests/UT_RpcServer.Wallet.cs * remove comment --------- Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * `[Move]` Part-3 Classes into Different Library - `Neo.Extensions` (#3400) * Part-1 `Neo.IO` - move * Part-2 * Added `BigInteger` to `Neo.Extensions` * Found more `BigInteger` * Added `ByteArray` to `Neo.Extensions` * Added Tests * Added `tests` from `Part-2` --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Jimmy <jinghui@wayne.edu> * [`Optimization`] Parsing Smart Contract Script Analysis (#3420) * Fixed Parsing Smart Contract Script Analysis * Add more opcode outputs * Bug fixes * Move to ToString * Reorder using * Change ToString --------- Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com> Co-authored-by: Fernando Diaz Toledano <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * update benchmark system (#3442) Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * [rpc] Extend `getversion` RPC response with additional protocol settings (#3443) * getversion * Extend client --------- Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * [Neo Core Add] add char support (#3441) * add char support * Update src/Neo/VM/Helper.cs * add char unit test --------- Co-authored-by: Shargon <shargon@gmail.com> * Stopped `RecoveryLogs` store from being created when `IgnoreRecoveryLogs` is `true` (#3444) Co-authored-by: Shargon <shargon@gmail.com> * [Neo Core Bug] fix compound type reference issue (#3334) * fix compound type reference issue * fix warning * add benchmark * throw exception instead * Update benchmarks/Neo.VM.Benchmarks/Benchmarks.Types.cs * Update src/Neo.VM/Types/Map.cs * Apply suggestions from code review * Update src/Neo.VM/Types/Map.cs Co-authored-by: Shargon <shargon@gmail.com> * update accessibality. --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Fix plugin exception (#3426) * Revert "Revert "Plugin unhandled exception (#3349)" (#3366)" This reverts commit f307a31. * ensure leveldb is not used in multithread env * Revert "Revert "Plugin unhandled exception (#3349)" (#3366)" This reverts commit f307a31. * remove async. * Update src/Neo/Plugins/UnhandledExceptionPolicy.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * not use linq * Update src/Neo/Plugins/UnhandledExceptionPolicy.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * use ignore case * Update src/Plugins/TokensTracker/TokensTracker.cs * Update src/Neo/Plugins/Plugin.cs Co-authored-by: Shargon <shargon@gmail.com> --------- Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * [Neo Json Fix] Json null tests (#3450) * null operation * fix array --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * Update README.md (#3459) * Update RpcServer.Blockchain.cs (#3458) Co-authored-by: Jimmy <jinghui@wayne.edu> * Set `Password` to `SecureString` for Wallet (#3468) * Set `Password` to `SecureString` for Wallet information * Added `UnitTest` for `SecureStringExtensions` * Update tests/Neo.Extensions.Tests/UT_SecureStringExtensions.cs Co-authored-by: Shargon <shargon@gmail.com> * Update src/Neo.Extensions/SecureStringExtensions.cs --------- Co-authored-by: Shargon <shargon@gmail.com> * [Neo Plugin RPCServer] Rpc parameters. Part I (#3457) * rpc parameter parse * update blockchain related apis. * Update src/Plugins/RpcServer/RpcMethodWithParamsAttribute.cs * Delete src/Plugins/RpcServer/JsonPropertyNameAttribute.cs * udpate contract model * Update src/Plugins/RpcServer/Model/BlockHashOrIndex.cs * Apply suggestions from code review Remove comments * Update src/Plugins/RpcServer/RpcServer.cs * fix warnings * ensure it can load both true/false and 1/0 * optimize the pr and add unit tests * add more tests and check the safe max value and safe min value * remove format * remove unused * format * Apply suggestions from code review --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * test RpcServer.Utilities, .SmartContract and .Wallet (#3461) * test RpcServer.Utilities * test invoke function and script * TestTraverseIterator * TestGetUnclaimedGas * RpcServerSettings.Default with { SessionEnabled = true } * test call with storage changes and events * use wallet in invokefunction * use invalid wallet * invoke without signer * all cases for TraverseIterator * traversing same session twice; not expired session * cover OnTimer * test deserializing complex signers * use Assert.ThrowsException * TestSendFrom and TestSendMany * apply code review with `nameof` * test cancel transaction * TestInvokeContractVerify * improve error message --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * `[Move]` Part-4 Classes into Different Library - `Neo.Extensions` (#3408) * Part-1 `Neo.IO` - move * Part-2 * Added `BigInteger` to `Neo.Extensions` * Found more `BigInteger` * Added `ByteArray` to `Neo.Extensions` * Added `DateTime` Extensions to `Neo.Extensions` * Added `HashSetExtensions`, `HashSetExtensions2`, `IpAddressExtensions`, `AssemblyExtensions`, `StringExtensdions` Deleted `Helper.cs` file * Added Tests * Added `tests` from `Part-2` * Added `tests` for `PART-4` * Add `using Neo.Extensions` for unit tests * Change `HashSetExtensions2` to `HashSetExtensions` * Update tests/Neo.Extensions.Tests/UT_BigIntegerExtensions.cs * Update and rename StringExtensdions.cs to StringExtensdios.cs * Rename StringExtensdios.cs to StringExtensions.cs * `dotnet format` --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Add UT Neo.IO (#3466) * UT_KeyedCollectionSlim * Update UT_KeyedCollectionSlim.cs * Update UT_MemoryReader.cs * Update UT_MemoryReader.cs * improve error message when wrong wallet is opened (#3469) * improve error message when wrong wallet is opened * update tests * Update UT RpcServer (#3460) * Update UT_RpcServer.Blockchain.cs * Update UT_RpcServer.Blockchain.cs * update * fixed bug * format * update * Update NativeContractExtensions.cs * update * Remove conflicting files * update * format * [`fixes`] UInt160 Class (#3422) * Fixed `UInt160` and expanded class * Cleaned up code for `TryParse` * Fixed `TryParse` * Fixed small bug with `TryParse` * Change `UInt160.Zero` to `static readonly` * benchmark UInt160 * Fix benchmark * Fixed bugs and added features for `UInt160` class * Revert and just keep bug fixes * Made @shargon changes * Set `InvariantCultureIgnoreCase` back for `0x` and `0X` --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Jimmy <jimmy@r3e.network> * test GetApplicationLog (#3470) * test GetApplicationLog * filter execution type * Test_Commands; refactor * apply review suggestions --------- Co-authored-by: Shargon <shargon@gmail.com> * Add UT Neo.Extensions (#3467) * Add UT Neo.Extensions * resolve conflicts * Revert "resolve conflicts" This reverts commit 6d0a61b. * add edge case * update mod test --------- Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Jimmy <jimmy@r3e.network> * Add some UT (#3476) * Update UT_Utility.cs * TestGetContractState * Update ConstantTimeUtility.cs (#3472) - Fix typo Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Test OracleService (#3475) * trigger https oracle * make it internal * return Task.CompletedTask --------- Co-authored-by: Jimmy <jimmy@r3e.network> Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Shargon <shargon@gmail.com> * [Neo Plugin RPC] update rpc node methods signatures to use explicit parameter types. (#3479) * update rpc node methods signatures to use explicit parameter types. * fix attribute place --------- Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: Shargon <shargon@gmail.com> * Fixing errors in comments (#3483) * Update OpCode.cs * Update JumpTable.Compound.cs * Update OpCode.cs * parse nef file scripts (#3482) * parse nef file scripts * nef file path support --------- Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com> * [Neo VM Style] Throw exception for Integer that is larger than 32 bytes (#3486) * fix push integer * Update src/Neo.VM/ScriptBuilder.cs * Update tests/Neo.VM.Tests/UT_ScriptBuilder.cs * Update tests/Neo.VM.Tests/UT_ScriptBuilder.cs * Update RpcError.cs (#3498) * fix: concurrency conflict in HeaderCache.Count (#3501) * fix: concurrency conflict in HeaderCache.Count * Update tests/Neo.UnitTests/Ledger/UT_HeaderCache.cs * Update tests/Neo.UnitTests/Ledger/UT_HeaderCache.cs --------- Co-authored-by: Shargon <shargon@gmail.com> * [`Add`] Transaction Builder (#3477) * Added Builders with tests * Added SignerBuilder and started WitnessRuleBuilder * Added `WitnessConditionBuilder` with tests * Added more logic * Fixed `SignerBuilder` class * Code touch ups * Added more tests * Update src/Neo/Builders/TransactionBuilder.cs * Fixed `And` `Or` and `Not` conditions * Fixed Memory leak * Added error message for Witness scripts --------- Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * [`Fix`] Neo Plugins github nuget (#3493) * Fixed Delete packages for github * Automatic * added continue-on-error: true --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * `[Move]` Part-5 Classes into Different Library - `Neo.Extensions` (#3409) * Part-1 `Neo.IO` - move * Part-2 * Added `BigInteger` to `Neo.Extensions` * Found more `BigInteger` * Added `ByteArray` to `Neo.Extensions` * Added `DateTime` Extensions to `Neo.Extensions` * Added `HashSetExtensions`, `HashSetExtensions2`, `IpAddressExtensions`, `AssemblyExtensions`, `StringExtensdions` Deleted `Helper.cs` file * Added `ICollection`, `Memory`, `String`, `Unsafe` extensions * Adding `using` * dotnet format * Added Tests * Added `tests` from `Part-2` * Added `tests` for `PART-4` * Added `tests` for `PART-5` * Made changes and fixes * Fixes * Apply suggestions from code review * Update tests/Neo.Extensions.Tests/UT_StringExtensions.cs * @shagron review changes * formating * Moved `UnsafeData` tests to `UT_UnsafeData` * Formating --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Jimmy <jinghui@wayne.edu> * fix: always throw `DivideByZeroException ` when `BloomFilter` is empty (#3502) * fix: always throw divided by zero when BloomFilter is empty * fix: always throw divided by zero when BloomFilter is empty * fix: concurrency conflict in MemPool.TryRemoveUnVerified (#3500) * fix: concurrency conflict in MemPool.TryRemoveUnVerified * Remove method * Update src/Neo/Ledger/MemoryPool.cs * clean * Apply suggestions from code review * reformat --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Jimmy <jinghui@wayne.edu> * update rvcount error message (#3504) * Added `CreateStruct` & Fixed `CreateMap` (#3494) * Added `CreateStruct`, Fixed CreateMap * Added test and comments --------- Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> Co-authored-by: Shargon <shargon@gmail.com> * benchmark convert (#3509) * OpCodes: extend MODMUL tests with negative base/multiplier/mod (#3513) Allows to avoid bugs like nspcc-dev/neo-go#3598. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: Jimmy <jinghui@wayne.edu> * fix: sensitive data compare should use constant time compare to avoid timing attack (#3508) * fix: pass compare should use contant time compare to avoid timing attack * fix: pass compare should use contant time compare to avoid timing attack * Update src/Plugins/RpcServer/RpcServer.cs * Update src/Plugins/RpcServer/RpcServer.cs --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Jimmy <jinghui@wayne.edu> * Related to #3508 (comment) (#3516) Co-authored-by: Jimmy <jinghui@wayne.edu> * [Benchmark] this pr adds more pocs to benchmark (#3512) * this pr adds more pocs to benchmark * format --------- Co-authored-by: Fernando Diaz Toledano <shargon@gmail.com> * Bump System.Text.Json from 8.0.4 to 8.0.5 in /src/Neo.Json (#3519) Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 8.0.4 to 8.0.5. - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v8.0.4...v8.0.5) --- updated-dependencies: - dependency-name: System.Text.Json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> Co-authored-by: Shargon <shargon@gmail.com> * Circular reference error info in ToJson (#3522) Co-authored-by: Shargon <shargon@gmail.com> * [Benchmark] Benchmark OpCode and VM (#3514) * add opcode benchmark system * add opcode benchmark system * update to make the framework easier to work with. * Clean code * filescope namespace * remove uncomplet benchmark * add missing using --------- Co-authored-by: Fernando Diaz Toledano <shargon@gmail.com> * Move `ReferenceCounter` to an interface (#3524) * Reference counter V2 * Remove warning * Interface * Change to interface * Update * Remove V2 * [Neo VM] optimize newstruct (#3525) * optimize newstruct * use Array.Fill * Update src/Neo.VM/JumpTable/JumpTable.Compound.cs --------- Co-authored-by: Shargon <shargon@gmail.com> * fea: use canonical TryGet style in IReadOnlyStore (#3533) * Add references (#3529) Co-authored-by: Jimmy <jinghui@wayne.edu> * fix: concurrency conflict in NEP6Wallet.ToJson (#3527) * fix: concurrency conflict in NEP6Wallet.ToJson * Update also ChangePasssword * Reduce lock time --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Jimmy <jinghui@wayne.edu> * fix cref "OpCode.SUBSTR" in comment (#3542) * ApplicationEngine helper to get engine error info (#3541) * helper to get engine error info * cancel try * Update src/Neo/SmartContract/ApplicationEngine.Helper.cs Co-authored-by: Shargon <shargon@gmail.com> * standalone method to get exception stack trace and message * always return string --------- Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Shargon <shargon@gmail.com> * stack opcode example comments (#3546) * stack opcode example comments * move index into example --------- Co-authored-by: Jimmy <jinghui@wayne.edu> * Expose `GetInteropDescriptor` (#3545) * Expose GetInteropDescriptor * Update src/Neo/SmartContract/ApplicationEngine.cs --------- Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: 陈志同 <bitcoin2077@outlook.com> Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> Co-authored-by: Owen <38493437+superboyiii@users.noreply.github.com> Co-authored-by: lingyido <lingyido@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com> Co-authored-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: Hecate2 <hecate2@qq.com> Co-authored-by: Hecate2 <2474101468@qq.com> Co-authored-by: Jimmy <jimmy@r3e.network> Co-authored-by: Mirage Mouse <bk@sundialmirage.com> Co-authored-by: nan01ab <yjcc201374@outlook.com>

fix compound type reference issue

3aeaedc

Jim8y added the Waiting for Review label Jun 13, 2024

fix warning

1fc70f3

Jim8y requested review from shargon, cschuchardt88, vncoelho, roman-khimov and AnnaShaleva June 13, 2024 03:10

vncoelho reviewed Jun 13, 2024

View reviewed changes

tests/Neo.VM.Tests/UT_ReferenceCounter.cs Show resolved Hide resolved

vncoelho reviewed Jun 13, 2024

View reviewed changes

Merge branch 'master' into fix-compound-reference

fb09d9a

shargon reviewed Jun 15, 2024

View reviewed changes

Jim8y mentioned this pull request Jun 15, 2024

[Neo VM Optimization] Detect reference counter miscalculation. #3325

Closed

15 tasks

roman-khimov reviewed Jun 27, 2024

View reviewed changes

Jim8y and others added 2 commits June 27, 2024 22:35

Merge branch 'master' into fix-compound-reference

2a2aaeb

add benchmark

d59521c

shargon mentioned this pull request Jun 28, 2024

null checks for #3364 and fix some bugs Jim8y/neo#1

Closed

Merge branch 'master' into fix-compound-reference

872baab

throw exception instead

62ec6e0

Merge branch 'master' into fix-compound-reference

d748d83

Jim8y mentioned this pull request Jul 26, 2024

【Aug.15】Core Dev Regular Meeting Proposal Discussion #3440

Closed

shargon reviewed Jul 29, 2024

View reviewed changes

benchmarks/Neo.Benchmarks/Program.cs Outdated Show resolved Hide resolved

benchmarks/Neo.VM.Benchmarks/Benchmarks.Types.cs Outdated Show resolved Hide resolved

src/Neo.VM/EvaluationStack.cs Show resolved Hide resolved

Update benchmarks/Neo.VM.Benchmarks/Benchmarks.Types.cs

c2a0a59

shargon reviewed Jul 29, 2024

View reviewed changes

src/Neo.VM/Types/Map.cs Outdated Show resolved Hide resolved

Jim8y and others added 2 commits July 29, 2024 20:04

Merge branch 'master' into fix-compound-reference

481293c

Update src/Neo.VM/Types/Map.cs

7e6a952

shargon reviewed Aug 1, 2024

View reviewed changes

src/Neo.VM/Types/Map.cs Outdated Show resolved Hide resolved

src/Neo.VM/Types/CompoundType.cs Outdated Show resolved Hide resolved

Apply suggestions from code review

4c03b33

shargon previously approved these changes Aug 1, 2024

View reviewed changes

shargon reviewed Aug 1, 2024

View reviewed changes

src/Neo.VM/Types/Map.cs Outdated Show resolved Hide resolved

Update src/Neo.VM/Types/Map.cs

774923f

Co-authored-by: Shargon <shargon@gmail.com>

Jim8y dismissed shargon’s stale review via 774923f August 1, 2024 13:33

shargon previously approved these changes Aug 1, 2024

View reviewed changes

Jim8y dismissed shargon’s stale review via 38c3c16 August 1, 2024 13:48

shargon previously approved these changes Aug 1, 2024

View reviewed changes

shargon self-requested a review August 1, 2024 14:05

update accessibality.

149d53d

Jim8y dismissed shargon’s stale review via 149d53d August 1, 2024 14:37

shargon approved these changes Aug 2, 2024

View reviewed changes

Jim8y requested review from vncoelho and roman-khimov August 2, 2024 11:53

cschuchardt88 approved these changes Aug 2, 2024

View reviewed changes

Jim8y added the Ready to Merge label Aug 2, 2024

Merge branch 'master' into fix-compound-reference

815bfe4

NGDAdmin merged commit 1dcec2e into neo-project:master Aug 6, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Neo Core Bug] fix compound type reference issue #3334

[Neo Core Bug] fix compound type reference issue #3334

Jim8y commented Jun 13, 2024 •

edited

Loading

vncoelho left a comment

shargon left a comment

Jim8y commented Jun 15, 2024

shargon commented Jun 18, 2024

Jim8y commented Jun 18, 2024 •

edited

Loading

roman-khimov Jun 27, 2024

Jim8y Jun 27, 2024

AnnaShaleva Jun 27, 2024

roman-khimov Jun 27, 2024

Jim8y Jun 28, 2024

Jim8y commented Jul 23, 2024

Jim8y commented Jul 23, 2024

Jim8y commented Jul 23, 2024 •

edited

Loading

shargon left a comment •

edited

Loading

[Neo Core Bug] fix compound type reference issue #3334

[Neo Core Bug] fix compound type reference issue #3334

Conversation

Jim8y commented Jun 13, 2024 • edited Loading

Description

Type of change

How Has This Been Tested?

Checklist:

vncoelho left a comment

Choose a reason for hiding this comment

shargon left a comment

Choose a reason for hiding this comment

Jim8y commented Jun 15, 2024

shargon commented Jun 18, 2024

Jim8y commented Jun 18, 2024 • edited Loading

roman-khimov Jun 27, 2024

Choose a reason for hiding this comment

Jim8y Jun 27, 2024

Choose a reason for hiding this comment

AnnaShaleva Jun 27, 2024

Choose a reason for hiding this comment

roman-khimov Jun 27, 2024

Choose a reason for hiding this comment

Jim8y Jun 28, 2024

Choose a reason for hiding this comment

Jim8y commented Jul 23, 2024

Jim8y commented Jul 23, 2024

Jim8y commented Jul 23, 2024 • edited Loading

shargon left a comment • edited Loading

Choose a reason for hiding this comment

Jim8y commented Jun 13, 2024 •

edited

Loading

Jim8y commented Jun 18, 2024 •

edited

Loading

Jim8y commented Jul 23, 2024 •

edited

Loading

shargon left a comment •

edited

Loading