Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new-cli] Part-1 - Base App #3372

Closed

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Jul 1, 2024

Description

PART-1

This is for new-cli branch

Features

  • All things in current CLI
  • Command-line based (With Prompt)
  • IPC NamedPipes (For Service)
  • Multi-Node support
  • Full Node
  • Lite Node
  • Development Node
  • Consensus Node
  • Debug Server
  • Smart Contract Tracer
  • Run as a OS Service
  • Offline mode
  • New archive/backup file format
  • Detailed mass logging - anything & everything
  • Plugin automation installation (download from nuget)
  • Expanded configuration file - (config.json removed)
  • New wallet management system

Fixes

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cschuchardt88 cschuchardt88 changed the title [new-cli] Added Part-1 [new-cli] Part-1 - Base App Jul 1, 2024
@cschuchardt88 cschuchardt88 requested review from Jim8y and shargon July 1, 2024 07:34
@@ -30,6 +30,7 @@
<InternalsVisibleTo Include="Neo.SmartContract.Testing" />
<InternalsVisibleTo Include="Neo.SmartContract.TestEngine" />
<InternalsVisibleTo Include="Neo.Plugins.RpcServer.Tests" />
<InternalsVisibleTo Include="neo-cmd" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange to me have two clients in the same repo, why don't improve the original one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It as bad as if I were to walk in outer space without a helmet on my head. What I am saying is it is to far gone, and needs to be redesigned anyways. This will solve tons of problems and issue, existing and future ones.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A whole new CLI will lead to code bloat and confusion for users. We need to improve on the CLI we have (keeping it compatible in the process).

Copy link
Member Author

@cschuchardt88 cschuchardt88 Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roman-khimov @shargon
All the code you see it the minimum amount to run neo-cli as a true background service for every OS all the way upto PART-7. Most of the code is to be able to interact with the cli as running as a service. All this could be added to neo-cli. But it just is easier to make new application, without hacking together for neo-cli to continue to work with other versions of neo core when they come out. Plus this is wanting to merge to branch new-cli. Once we get to the point of determining release or features or anything else, we can merge to master. This is a one-in-all solution to neo-express, neo-cli, android, IOS and different node types, like archival, full, half, development. I just don't do this for fun of it. Just filtering out the bad and keeping the good. This could be a a replacement for noo-cli, But I wouldn't recommend it. Let it be there for users if they want to do.

@cschuchardt88 cschuchardt88 added the Blocker Issues that are blocking other issues. Check issues details to see what it is blocking. label Jul 7, 2024
@Jim8y
Copy link
Contributor

Jim8y commented Jul 16, 2024

Maybe use some prefix like newcli to differ the folder for new cli

@cschuchardt88
Copy link
Member Author

Maybe use some prefix like newcli to differ the folder for new cli

This is more of the host for background services with fallback.

@cschuchardt88
Copy link
Member Author

Going different route with this. Going to build a NamedPipe Plugin for the node and Service app.

@cschuchardt88 cschuchardt88 deleted the rebuild/new-cli-1 branch November 17, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Issues that are blocking other issues. Check issues details to see what it is blocking. Waiting for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants