Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change references to IReferenceCounter #3529

Merged
merged 2 commits into from
Oct 14, 2024
+11 −10
Merged

Change references to IReferenceCounter #3529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4091ede
Add references
shargon Oct 11, 2024
fbdef08
Merge branch 'master' into fix-references
Jim8y Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions benchmarks/Neo.VM.Benchmarks/TestArray.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ public TestArray(IEnumerable<StackItem>? items = null)
}

/// <summary>
/// Create an array containing the specified items. And make the array use the specified <see cref="ReferenceCounter"/>.
/// Create an array containing the specified items. And make the array use the specified <see cref="IReferenceCounter"/>.
/// </summary>
/// <param name="referenceCounter">The <see cref="ReferenceCounter"/> to be used by this array.</param>
/// <param name="referenceCounter">The <see cref="IReferenceCounter"/> to be used by this array.</param>
/// <param name="items">The items to be included in the array.</param>
public TestArray(IReferenceCounter? referenceCounter, IEnumerable<StackItem>? items = null)
: base(referenceCounter)
Expand Down
4 changes: 2 additions & 2 deletions benchmarks/Neo.VM.Benchmarks/TestStruct.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ public TestStruct(IEnumerable<StackItem>? fields = null)
}

/// <summary>
/// Create a structure with the specified fields. And make the structure use the specified <see cref="ReferenceCounter"/>.
/// Create a structure with the specified fields. And make the structure use the specified <see cref="IReferenceCounter"/>.
/// </summary>
/// <param name="referenceCounter">The <see cref="ReferenceCounter"/> to be used by this structure.</param>
/// <param name="referenceCounter">The <see cref="IReferenceCounter"/> to be used by this structure.</param>
/// <param name="fields">The fields to be included in the structure.</param>
public TestStruct(IReferenceCounter? referenceCounter, IEnumerable<StackItem>? fields = null)
: base(referenceCounter, fields)
Expand Down
5 changes: 3 additions & 2 deletions src/Neo.VM/ExecutionEngine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,17 +83,18 @@ protected internal set
/// <summary>
/// Initializes a new instance of the <see cref="ExecutionEngine"/> class.
/// </summary>
/// <param name="jumpTable">The jump table to be used.</param>
public ExecutionEngine(JumpTable? jumpTable = null) : this(jumpTable, new ReferenceCounter(), ExecutionEngineLimits.Default)
{
}

/// <summary>
/// Initializes a new instance of the <see cref="ExecutionEngine"/> class with the specified <see cref="VM.ReferenceCounter"/> and <see cref="ExecutionEngineLimits"/>.
/// Initializes a new instance of the <see cref="ExecutionEngine"/> class with the specified <see cref="VM.IReferenceCounter"/> and <see cref="ExecutionEngineLimits"/>.
/// </summary>
/// <param name="jumpTable">The jump table to be used.</param>
/// <param name="referenceCounter">The reference counter to be used.</param>
/// <param name="limits">Restrictions on the VM.</param>
protected ExecutionEngine(JumpTable? jumpTable, ReferenceCounter referenceCounter, ExecutionEngineLimits limits)
protected ExecutionEngine(JumpTable? jumpTable, IReferenceCounter referenceCounter, ExecutionEngineLimits limits)
{
JumpTable = jumpTable ?? JumpTable.Default;
Limits = limits;
Expand Down
4 changes: 2 additions & 2 deletions src/Neo.VM/Types/Array.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ public Array(IEnumerable<StackItem>? items = null)
}

/// <summary>
/// Create an array containing the specified items. And make the array use the specified <see cref="ReferenceCounter"/>.
/// Create an array containing the specified items. And make the array use the specified <see cref="IReferenceCounter"/>.
/// </summary>
/// <param name="referenceCounter">The <see cref="ReferenceCounter"/> to be used by this array.</param>
/// <param name="referenceCounter">The <see cref="IReferenceCounter"/> to be used by this array.</param>
/// <param name="items">The items to be included in the array.</param>
public Array(IReferenceCounter? referenceCounter, IEnumerable<StackItem>? items = null)
: base(referenceCounter)
Expand Down
4 changes: 2 additions & 2 deletions src/Neo.VM/Types/Struct.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ public Struct(IEnumerable<StackItem>? fields = null)
}

/// <summary>
/// Create a structure with the specified fields. And make the structure use the specified <see cref="ReferenceCounter"/>.
/// Create a structure with the specified fields. And make the structure use the specified <see cref="IReferenceCounter"/>.
/// </summary>
/// <param name="referenceCounter">The <see cref="ReferenceCounter"/> to be used by this structure.</param>
/// <param name="referenceCounter">The <see cref="IReferenceCounter"/> to be used by this structure.</param>
/// <param name="fields">The fields to be included in the structure.</param>
public Struct(IReferenceCounter? referenceCounter, IEnumerable<StackItem>? fields = null)
: base(referenceCounter, fields)
Expand Down
Loading