Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Xxhash3 for StorageKey.GetHashCode #3559

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

nan01ab
Copy link
Contributor

@nan01ab nan01ab commented Nov 1, 2024

Description

I found StorageKey.GetHashCode consumes some CPU resources on when I do some rpc methods performance tests.

This is a simple change that can improve performance.

#3543

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shargon shargon self-requested a review November 2, 2024 12:03
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard fork params come later,right?

src/Neo/SmartContract/StorageKey.cs Show resolved Hide resolved
@nan01ab
Copy link
Contributor Author

nan01ab commented Nov 3, 2024

Hard fork params come later,right?

No need for hardfork

Jim8y
Jim8y previously approved these changes Nov 3, 2024
@Jim8y
Copy link
Contributor

Jim8y commented Nov 3, 2024

LGTM

@Jim8y
Copy link
Contributor

Jim8y commented Nov 3, 2024

Hard fork params come later,right?

Its not needed, this just avoid redundency computing.

shargon
shargon previously requested changes Nov 4, 2024
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HashCode.Combine, like others, we should not use different ways in different areas of the code

@nan01ab
Copy link
Contributor Author

nan01ab commented Nov 4, 2024

HashCode.Combine, like others, we should not use different ways in different areas of the code

Changed to HashCode.Combine

Jim8y
Jim8y previously approved these changes Nov 4, 2024
shargon
shargon previously approved these changes Nov 5, 2024
shargon
shargon previously approved these changes Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants