-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use Xxhash3
for StorageKey.GetHashCode
#3559
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard fork params come later,right?
No need for hardfork |
LGTM |
Its not needed, this just avoid redundency computing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HashCode.Combine, like others, we should not use different ways in different areas of the code
Changed to |
Description
I found
StorageKey.GetHashCode
consumes some CPU resources on when I do some rpc methods performance tests.This is a simple change that can improve performance.
#3543
Type of change
Checklist: