.NET 9 #3576
.NET 9 #3576
Conversation
| @@ -126,7 +126,7 @@ public ScriptBuilder EmitPush(bool value) | |||
| /// <returns>A reference to this instance after the emit operation has completed.</returns> | |||
| public ScriptBuilder EmitPush(ReadOnlySpan<byte> data) | |||
| { | |||
| if (data == null) | |||
| @@ -54,7 +54,7 @@ public void TestGetBitLength() | |||
| var random = new Random(); | |||
|
|
|||
| // Big Number (net standard didn't work) | |||
| VerifyGetBitLength(BigInteger.One << 32 << int.MaxValue, 2147483680); | |||
| Assert.ThrowsException<OverflowException>(() => VerifyGetBitLength(BigInteger.One << 32 << int.MaxValue, 2147483680)); | |||
There was a problem hiding this comment.
why is this change? the behavor is no longer the same?
There was a problem hiding this comment.
BigInteger.One << 32 << int.MaxValue will throw OverflowException in .net 9
| @@ -25,7 +25,7 @@ public class UT_ByteExtensions | |||
| public void TestToHexString() | |||
| { | |||
| byte[] nullStr = null; | |||
| Assert.ThrowsException<NullReferenceException>(() => nullStr.ToHexString()); | |||
| Assert.ThrowsException<ArgumentNullException>(() => nullStr.ToHexString()); | |||
There was a problem hiding this comment.
does this mean Net9.0 has changed the exception type?
There was a problem hiding this comment.
does this mean Net9.0 has changed the exception type?
ToHexString uses Convert.ToHexStrongLower when run with NET.9.
May need to add an argument null-check to keep same semantics.
|
I rather not go to Also you missed |
I didn't miss global.json {
"sdk": {
"version": "9.0.100",
"rollForward": "latestFeature",
"allowPrerelease": false
}
}I’m not sure whether to upgrade to .NET 9. I'll leave it up to you core developers to decide! |
|
I am in favor, next year we move to long term again and so on. |
me too |
|
This will break the functionally of |
No dont leave it up to them. If it's dotnet 9.0 then have to upgrade. there is no way around it. |
Because some of the exception types change, and some of the dotnet format rules change. |
That's true |
src/Neo.VM/ScriptBuilder.cs
Outdated
| @@ -126,7 +126,8 @@ public ScriptBuilder EmitPush(bool value) | |||
| /// <returns>A reference to this instance after the emit operation has completed.</returns> | |||
| public ScriptBuilder EmitPush(ReadOnlySpan<byte> data) | |||
| { | |||
| if (data == null) | |||
| ReadOnlySpan<byte> nullData = null; | |||
There was a problem hiding this comment.
Because if (data == null) will fail the format check in .net 9.
| @@ -28,7 +29,8 @@ public static bool NotNull(this StackItem item) | |||
|
|
|||
| public static string ToBase64(this ReadOnlySpan<byte> item) | |||
| { | |||
| return item == null ? String.Empty : Convert.ToBase64String(item); | |||
| ReadOnlySpan<byte> nullData = null; | |||
There was a problem hiding this comment.
Because item == null will fail the format check in .net 9.
There was a problem hiding this comment.
We should add test to ensure if IsEmpty check null and not Length != 0
There was a problem hiding this comment.
Running dotnet format automatically changes item == null to item.IsEmpty. If you use item.IsEmpty, the unit test will fail, I tried it. So I've changed it to ReadOnlySpan<byte> nullData = null; item == nullData;
There was a problem hiding this comment.
just edit the .editorconfig and turn that off.
update to .net 9