Make PoolItem independent and add PoolItem tests #562

igormcoelho · 2019-01-18T15:56:03Z

I believe PoolItem should be an independent class, and this would help creating tests specific for it too.
This should simplify a little bit the understanding of MemoryPool class, which is already quite big right now.

vncoelho · 2019-01-18T16:02:28Z

Perfect, brother, I think it will be better for organization and tests as you mentioned.

neo/Ledger/PoolItem.cs

jsolman

Can we make this PR also include the tests if we are doing this. Before this PoolItem is private. This will need to mark it internal. I would like to see the tests in this same PR that moves this out to see the value we are getting in moving this out.

neo/Ledger/PoolItem.cs

…o poolitem_independent

igormcoelho · 2019-01-18T17:11:14Z

@vncoelho now we have a sketch to test all features here. Let's make sure it behaves as expected.

neo/Ledger/PoolItem.cs

vncoelho · 2019-01-18T18:32:21Z

Basic? ahueahueaea
Beautiful tests

concern was addressed

neo.UnitTests/UT_PoolItem.cs

…omparison tests.

igormcoelho · 2019-01-19T00:51:43Z

neo.UnitTests/UT_PoolItem.cs

-            timeMock.SetupGet(tp => tp.UtcNow).Returns(() => timeValues[timeIndex])
-                                              .Callback(() => timeIndex++);
+            timeMock.SetupGet(tp => tp.UtcNow).Returns(() => timeValues[0])
+                                              .Callback(() => timeValues[0] = timeValues[0].Add(TimeSpan.FromSeconds(1)));


Nice idea!!

* Handles escape characters in JSON * Pass ApplicationExecution to IPersistencePlugin (neo-project#531) * Update dependencies: (neo-project#532) - Akka 1.3.11 - Microsoft.AspNetCore.ResponseCompression 2.2.0 - Microsoft.AspNetCore.Server.Kestrel 2.2.0 - Microsoft.AspNetCore.Server.Kestrel.Https 2.2.0 - Microsoft.AspNetCore.WebSockets 2.2.0 - Microsoft.EntityFrameworkCore.Sqlite 2.2.0 - Microsoft.Extensions.Configuration.Json 2.2.0 * change version to v2.9.4 * Updating Unknown to Policy Fail (neo-project#533) * Fix a dead lock in `WalletIndexer` * Downgrade Sqlite to 2.1.4 (neo-project#535) * RPC call gettransactionheight (neo-project#541) * getrawtransactionheight Nowadays two calls are need to get a transaction height, `getrawtransaction` with `verbose` and then use the `blockhash`. Other option is to use `confirmations`, but it can be misleading. * Minnor fix * Shargon's tip * modified * Allow to use the wallet inside a RPC plugin (neo-project#536) * Improve Large MemoryPool Performance - Sort + intelligent TX reverification (neo-project#500) Improve Large MemoryPool Performance - Sort + intelligent TX reverification (neo-project#500) * Keep both verified and unverified (previously verified) transactions in sorted trees so ejecting transactions above the pool size is a low latency operation. * Re-verify unverified transactions when Blockchain actor is idle. * Don't re-verify transactions needlessly when not at the tip of the chain. * Support passing a flag to `getrawmempool` to retrieve both verified and unverified TX hashes. * Support MaxTransactionsPerBlock and MaxFreeTransactionsPerBlock from Policy plugins. * Rebroadcast re-verified transactions if it has been a while since last broadcast (high priority transactions are rebroadcast more frequently than low priority transactions. * Policy filter GetRelayResult message (neo-project#543) * Policy filter GetRelayResult message * adding fixed numbering for return codes * Removed enum fixed values * Add some initial MemoryPool unit tests. Fix bug when Persisting the GenesisBlock (neo-project#549) * More MemoryPool Unit Tests. Improve Re-broadcast back-off to an increasing linear formula. (neo-project#554) * Ensuring Object Reference check of SortedSets for speed-up (neo-project#557) * Minor comments update on Mempool class (neo-project#556) * Update MemoryPool Unit Test to add random fees to Mock Transactions (neo-project#558) * Add Unit Test for MemoryPool sort order. Fixed sort order to return descending. (neo-project#559) * Add unit test to verify memory pool sort order and reverification order. Fixed sort order bug. * VerifyCanTransactionFitInPool works as intended. Also inadvertantly verified GetLowestFeeTransaction() works. * Benchmark structure for UInt classes (neo-project#553) * basic benchmark structure for UInt classes * commented code2 from lights for now * updated tests. all seem correct now * Switch to using a benchmark method taking a method delegate to benchmark. * Make pass. * 1 million iterations. * Switch to ulong for the 4th option, and it is still the same speed. * fix test data for 50% equal data * make test pass * neo.UnitTests/UT_UIntBenchmarks.cs * neo.UnitTests/UT_UIntBenchmarks.cs * Base 20 - UInt160 tests * neo.UnitTests/UT_UIntBenchmarks.cs * inlined 160 * complete tests with UInt256 and UInt160 * neo.UnitTests/UT_UIntBenchmarks.cs * Lights division calculation * Treat lower hashes as higher priority. Fix MemoryPool UT for Hash order. (neo-project#563) * Treat lower hashes as higher priority. * Fix MemoryPool UT for Hash order. * Renaming Trasanction in PoolItem for clarity. * Make PoolItem independent and add PoolItem tests (neo-project#562) * make poolitem independent * Merging * Multiply by -1 * Fix other * Fix Tx * Removing -1 extra multiplication * Fix * make PoolItem internal and added test class * Update PoolItem.cs * added comments for PoolItem variables * getting time from TimeProvider to allow testing * basic test * reset time provider * Add Hash comparison * Adding time provider again and equals * Fix arithmetic * Comment on PoolItem * Update PoolItem.cs * protecting tests against TimeProvider changes on fails * reusing setup part * fixed serialization properties * Improve generation of creating mock DateTime values. Implement hash comparison tests. * Adjust comment. * Treat Claim transactions as the highest low priority transactions. (neo-project#565) * Allow persistence plugins to commit as a final step. (neo-project#568) * Allow persistence plugins to commit as a final step. * Plugins commit before core commits, once all plugins have handled initial work OnPersist. * Allow PersistencePlugin to determine whether to crash if commit fails. * Add ShouldThrowExceptionFromCommit method to IPersistencePlugin. * Throw all commit exceptions that should be thrown in an AggregateException. * Add a Plugin type for observing transactions added or removed from the MemoryPool. (neo-project#580) * Correctly handle conversions between JSON objects (neo-project#586) * Fix neo-project/neo-node#297 (neo-project#587) * Replace new JArray with .ToArray (AccountState) (neo-project#581) * Ensure `LocalNode` to be stoped before shutting down the `NeoSystem`

* make poolitem independent * Merging * Multiply by -1 * Fix other * Fix Tx * Removing -1 extra multiplication * Fix * make PoolItem internal and added test class * Update PoolItem.cs * added comments for PoolItem variables * getting time from TimeProvider to allow testing * basic test * reset time provider * Add Hash comparison * Adding time provider again and equals * Fix arithmetic * Comment on PoolItem * Update PoolItem.cs * protecting tests against TimeProvider changes on fails * reusing setup part * fixed serialization properties * Improve generation of creating mock DateTime values. Implement hash comparison tests. * Adjust comment.

* update voting * link issue * updated * add English version

make poolitem independent

c52b6d7

vncoelho previously approved these changes Jan 18, 2019

View reviewed changes

jsolman previously requested changes Jan 18, 2019

View reviewed changes

neo/Ledger/PoolItem.cs Outdated Show resolved Hide resolved

igormcoelho mentioned this pull request Jan 18, 2019

Treat lower hashes as higher priority. Fix MemoryPool UT for Hash order. #563

Merged

vncoelho added 2 commits January 18, 2019 14:39

Merge branch 'master' into poolitem_independent

b7bc0cf

Merging

a21a245

vncoelho dismissed their stale review via a21a245 January 18, 2019 16:41

Multiply by -1

da69487

jsolman reviewed Jan 18, 2019

View reviewed changes

neo/Ledger/PoolItem.cs Outdated Show resolved Hide resolved

vncoelho added 3 commits January 18, 2019 14:52

Fix other

47fdfbb

Fix Tx

7359828

Removing -1 extra multiplication

7dbd0c5

vncoelho changed the title ~~Make PoolItem independent~~ Make PoolItem independent and add PoolItem tests Jan 18, 2019

vncoelho and others added 4 commits January 18, 2019 15:02

Fix

ca8da1a

make PoolItem internal and added test class

65238ba

Update PoolItem.cs

3ec6ec5

Merge branch 'poolitem_independent' of github.com:igormcoelho/neo int…

7dba81b

…o poolitem_independent

igormcoelho added 2 commits January 18, 2019 15:14

added comments for PoolItem variables

f28b6b6

getting time from TimeProvider to allow testing

117582a

jsolman reviewed Jan 18, 2019

View reviewed changes

neo/Ledger/PoolItem.cs Show resolved Hide resolved

basic test

31c91d1

igormcoelho and others added 5 commits January 18, 2019 16:38

reset time provider

4918fd6

Add Hash comparison

c5dd31e

Adding time provider again and equals

5e39f5f

Fix arithmetic

f79e89a

Comment on PoolItem

d65d963

jsolman reviewed Jan 18, 2019

View reviewed changes

neo.UnitTests/UT_PoolItem.cs Outdated Show resolved Hide resolved

jsolman and others added 4 commits January 18, 2019 11:36

Update PoolItem.cs

2bc7608

protecting tests against TimeProvider changes on fails

9bd9325

reusing setup part

39a55d2

fixed serialization properties

91a57b8

jsolman reviewed Jan 18, 2019

View reviewed changes

neo.UnitTests/UT_PoolItem.cs Outdated Show resolved Hide resolved

jsolman suggested changes Jan 18, 2019

View reviewed changes

neo.UnitTests/UT_PoolItem.cs Outdated Show resolved Hide resolved

Improve generation of creating mock DateTime values. Implement hash c…

8020e58

…omparison tests.

jsolman previously approved these changes Jan 18, 2019

View reviewed changes

Adjust comment.

c059fea

jsolman dismissed their stale review via c059fea January 18, 2019 22:31

jsolman approved these changes Jan 18, 2019

View reviewed changes

igormcoelho commented Jan 19, 2019

View reviewed changes

igormcoelho merged commit 370d7a2 into neo-project:master Jan 19, 2019

txhsl mentioned this pull request Feb 25, 2019

Update from master branch txhsl/neo#2

Merged

Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020

Enhance voting (neo-project#562)

14ec878

* update voting * link issue * updated * add English version

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make PoolItem independent and add PoolItem tests #562

Make PoolItem independent and add PoolItem tests #562

igormcoelho commented Jan 18, 2019 •

edited

Loading

vncoelho commented Jan 18, 2019

jsolman left a comment •

edited

Loading

igormcoelho commented Jan 18, 2019

vncoelho commented Jan 18, 2019

igormcoelho Jan 19, 2019

Make PoolItem independent and add PoolItem tests #562

Make PoolItem independent and add PoolItem tests #562

Conversation

igormcoelho commented Jan 18, 2019 • edited Loading

vncoelho commented Jan 18, 2019

jsolman left a comment • edited Loading

Choose a reason for hiding this comment

igormcoelho commented Jan 18, 2019

vncoelho commented Jan 18, 2019

igormcoelho Jan 19, 2019

Choose a reason for hiding this comment

igormcoelho commented Jan 18, 2019 •

edited

Loading

jsolman left a comment •

edited

Loading