Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to change MaxConnectionsPerAddress #632

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Allow to change MaxConnectionsPerAddress #632

merged 1 commit into from
Mar 13, 2019

Conversation

shargon
Copy link
Member

@shargon shargon commented Mar 11, 2019 •
edited by erikzhang
Loading

Closes #630

@vncoelho
Copy link
Member

vncoelho commented Mar 11, 2019 •
edited
Loading

@shargon, it looks good to me, we need to PR on neo-cli as well, right:

Settings.cs(56,89): error CS0117: 'Peer' does not contain a definition for 'DefaultMinDesiredConnections' [/opt/neoCli/neo-cli/neo-cli.csproj]
Settings.cs(57,75): error CS0117: 'Peer' does not contain a definition for 'DefaultMaxConnections' [/opt/neoCli/neo-cli/neo-c

@shargon shargon requested a review from erikzhang March 11, 2019 17:23
jsolman
jsolman reviewed Mar 11, 2019
View reviewed changes
Copy link
Contributor

@jsolman jsolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why shouldn’t the maximums be set in the same place where the ip and port is set?

neo/protocol.json Outdated Show resolved Hide resolved
neo/NeoSystem.cs Outdated Show resolved Hide resolved
@erikzhang
Copy link
Member

I agree with @jsolman. We should set MaxConnectionsPerAddress in config.json.

@shargon shargon closed this Mar 12, 2019
@shargon shargon reopened this Mar 12, 2019
@erikzhang erikzhang merged commit 6e3eacf into neo-project:master Mar 13, 2019
@shargon shargon deleted the new-settings branch March 13, 2019 08:52
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
@Celia18305
update plug-in (neo-project#632)
e5d773e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsolman jsolman jsolman approved these changes

@erikzhang erikzhang Awaiting requested review from erikzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shargon @vncoelho @erikzhang @jsolman