Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new abstract method #650

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Fix new abstract method #650

merged 2 commits into from
Mar 21, 2019

Conversation

shargon
Copy link
Member

@shargon shargon commented Mar 21, 2019

Needed for the change neo-project/neo-vm#87

@shargon shargon requested a review from erikzhang March 21, 2019 09:11
@shargon shargon merged commit 19689fb into neo-project:master Mar 21, 2019
@erikzhang
Copy link
Member

We should wait for the next release to make this kind of changes.

@shargon shargon deleted the fix-vm-change branch March 21, 2019 16:51
@shargon
Copy link
Member Author

shargon commented Mar 21, 2019

It is not incompatible with the current one because we change from virtual to abstract

@jsolman
Copy link
Contributor

jsolman commented Mar 21, 2019

I approved it because the change looked compatible with the current version since the method already existed before as a virtual method.

Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants