Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Require locking agreement to ChangeView and allowing committed nodes to move to higher views #653

Closed
wants to merge 23 commits into from
Closed

[DRAFT] Require locking agreement to ChangeView and allowing committed nodes to move to higher views #653

wants to merge 23 commits into from

Commits on Mar 24, 2019

  1. Restore Liveness: Prevent Commit after ChangeView. Require locking ag… 

    …reement to ChangeView.
    @jsolman
    jsolman committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    3f56ceb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into consensus/liveness

    @shargon
    shargon authored Mar 24, 2019
    Configuration menu
    Copy the full SHA
    7b36d00 View commit details
    Browse the repository at this point in the history

  3. To prevent duplicate blocks, since we allow commits to move, we canno… 

    …t lock changing view if we have sent prepare response.
    @jsolman
    jsolman committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    4edf61f View commit details
    Browse the repository at this point in the history

  4. Fix log message.

    @jsolman
    jsolman committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    6099547 View commit details
    Browse the repository at this point in the history

  5. Add additional criteria for sending recovery since we must recover no… 

    …des that missed prepare response.
    @jsolman
    jsolman committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    01be5aa View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into consensus/liveness

    @jsolman
    jsolman authored Mar 24, 2019
    Configuration menu
    Copy the full SHA
    d4d233a View commit details
    Browse the repository at this point in the history

  7. Fix logic for inhibiting locking commit.

    @jsolman
    jsolman committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    87d61cb View commit details
    Browse the repository at this point in the history

  8. Primary should always help recover nodes missing prepare response.

    @jsolman
    jsolman committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    f795cf8 View commit details
    Browse the repository at this point in the history

  9. Need to be able to recover commit in the same view.

    @jsolman
    jsolman committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    51fbbf7 View commit details
    Browse the repository at this point in the history

  10. Fix bug in sending recovery logic.

    @jsolman
    jsolman committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    770ca57 View commit details
    Browse the repository at this point in the history

  11. Fix recovery response logic.

    @jsolman
    jsolman committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    00a5e0a View commit details
    Browse the repository at this point in the history

  12. Adjust logic for inhibiting view changing since now locking view chan… 

    …ge is inhibitted if a validator has sent its preparation.
    @jsolman
    jsolman committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    b4ded67 View commit details
    Browse the repository at this point in the history

  13. Simplify.

    @jsolman
    jsolman committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    900baac View commit details
    Browse the repository at this point in the history

  14. Make all respond for now for shouldRecoverPrepareResponseInSameView.

    @jsolman
    jsolman committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    9b59e5c View commit details
    Browse the repository at this point in the history

  15. Minor naming refactor.

    @jsolman
    jsolman committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    da33693 View commit details
    Browse the repository at this point in the history

  16. Move logic for whether to send recovery from OnChangeView into a meth… 

    …od for clarity.
    @jsolman
    jsolman committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    e54638c View commit details
    Browse the repository at this point in the history

  17. Clean-up.

    @jsolman
    jsolman committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    38f1550 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2019

  1. Added needed special logic to handle recovering while the view is cha… 

    …nging.
    @jsolman
    jsolman committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    42a5832 View commit details
    Browse the repository at this point in the history

  2. Fix threshold for valid preparations and sending prepare response fro… 

    …m recovery.
    @jsolman
    jsolman committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    e7e67d5 View commit details
    Browse the repository at this point in the history

  3. Fix calculating valid preparations during recovery while changing view.

    @jsolman
    jsolman committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    0c194e9 View commit details
    Browse the repository at this point in the history

  4. Primary doesn't send requests to change view.

    @jsolman
    jsolman committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    f75e037 View commit details
    Browse the repository at this point in the history

  5. Adding some comments and notes

    @vncoelho
    vncoelho committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    23586db View commit details
    Browse the repository at this point in the history

  6. Updating notes

    @vncoelho
    vncoelho committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    67d53f0 View commit details
    Browse the repository at this point in the history