Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consensus change view #693

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Fix consensus change view #693

merged 1 commit into from
Apr 8, 2019

Conversation

erikzhang
Copy link
Member

No description provided.

Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is true, @erikzhang.
Eagle eyes.

I think that this was not causing problems, right? However, it avoids the processing of payloads that will not be used.

@erikzhang
Copy link
Member Author

I think that this was not causing problems, right? However, it avoids the processing of payloads that will not be used.

Yes, it is. It will cause a switch to a lower view number.

@erikzhang
Copy link
Member Author

image

@erikzhang erikzhang merged commit a69b0ce into master Apr 8, 2019
@erikzhang erikzhang deleted the fixes/changeview branch April 8, 2019 03:21
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants