Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in consensus #698

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Fix crash in consensus #698

merged 1 commit into from
Apr 10, 2019

Conversation

erikzhang
Copy link
Member

No description provided.

vncoelho
vncoelho reviewed Apr 10, 2019
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is a necessary check. Nice catch.

igormcoelho
igormcoelho reviewed Apr 10, 2019
View reviewed changes
Copy link
Contributor

@igormcoelho igormcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erik, if this may fail, we should enforce somewhere else too, no?

igormcoelho
igormcoelho approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@igormcoelho igormcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I tried all invocations of OnConsensusPayload, and we have at least two... so instead of replicating code, this can be effectively the best place to put this code.

@shargon shargon merged commit 3a06f9c into master Apr 10, 2019
@shargon shargon deleted the fixes/crash_in_consensus branch April 10, 2019 17:55
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
@Celia18305
update exchange (neo-project#698)
780b444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vncoelho vncoelho vncoelho left review comments

@shargon shargon shargon approved these changes

@igormcoelho igormcoelho igormcoelho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erikzhang @igormcoelho @shargon @vncoelho