Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean unit test and follow some visual studio hints #792

Merged
merged 3 commits into from
May 31, 2019

Conversation

shargon
Copy link
Member

@shargon shargon commented May 31, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented May 31, 2019

Codecov Report

Merging #792 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #792   +/-   ##
=======================================
  Coverage   37.75%   37.75%           
=======================================
  Files         176      176           
  Lines       12439    12439           
=======================================
  Hits         4696     4696           
  Misses       7743     7743

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e365f00...7d0d357. Read the comment docs.

Copy link
Member

@erikzhang erikzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfectionist

@shargon shargon merged commit a8ada56 into neo-project:master May 31, 2019
@shargon shargon deleted the indentation-test branch May 31, 2019 13:46
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants