Test for Akka Mailboxes #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need more tests for 2.x? I think we can add more tests for 3.0. |
|
I'll backport all of them Erik, we need to have both projects solid. |
vncoelho
approved these changes
Jun 10, 2019
There was a problem hiding this comment.
@igormcoelho, such a nice and precise tests!
You are becoming a master in these UTs.
Let's include this tests on both. It will be good for the history of the project.
|
@shargon can we merge this? @erikzhang I don't intend to go very deep on tests for 2.x now, the focus is on 3.0, but at least these tests validate previous changes on protocol handler and open door for future testings on other mailboxes, when necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful tests for p2p protocol and all mailboxes.
Right now it's working already for Protocol Handler mailbox.