Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Runtime.CheckMultiWitness #835

Conversation

igormcoelho
Copy link
Contributor

closes #834

@codecov-io
Copy link

codecov-io commented Jun 15, 2019

Codecov Report

Merging #835 into master will decrease coverage by 0.11%.
The diff coverage is 2.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #835      +/-   ##
==========================================
- Coverage   38.39%   38.28%   -0.12%     
==========================================
  Files         176      176              
  Lines       12465    12504      +39     
==========================================
+ Hits         4786     4787       +1     
- Misses       7679     7717      +38
Impacted Files Coverage Δ
neo/SmartContract/InteropService.cs 19.34% <2.56%> (-1.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d63f0ed...2099eda. Read the comment docs.

@erikzhang
Copy link
Member

Please do not implement proposals that have not been discussed. 😂

@igormcoelho
Copy link
Contributor Author

igormcoelho commented Jun 16, 2019

Please do not implement proposals that have not been discussed.

Sometimes is easier to express in coding than in text ;) hahahha but it's just a reference, we can close it.

But it was proposed many months ago Erik, I just re-proposed it: #700

@vncoelho
Copy link
Member

Beautiful, @igormcoelho, this is a powerful and important feature.
The explanation and details in #834 are clear, good examples.
I believe that we should move in this direction and make this a standard.

@codecov-io
Copy link

codecov-io commented Jun 17, 2019

Codecov Report

Merging #835 into master will decrease coverage by 0.12%.
The diff coverage is 2.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #835      +/-   ##
==========================================
- Coverage   43.57%   43.44%   -0.13%     
==========================================
  Files         177      177              
  Lines       12547    12586      +39     
==========================================
+ Hits         5467     5468       +1     
- Misses       7080     7118      +38
Impacted Files Coverage Δ
neo/SmartContract/InteropService.cs 19.5% <2.56%> (-1.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90fa9af...43e3feb. Read the comment docs.

@vncoelho
Copy link
Member

This is a good standard to have, @igormcoelho, for being efficient we could also have a search for deployed verification's.
Then, we would not need to provide all verifications at the same time.

@igormcoelho
Copy link
Contributor Author

Closing this now, pehaps come back in the future.

@igormcoelho igormcoelho deleted the feat_3x_runtime_checkmultiwitness branch June 28, 2019 10:12
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Witness Checking (Neo 3)
4 participants