Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting TaskManager FIFOSet init #876

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Conversation

vncoelho
Copy link
Member

@vncoelho vncoelho commented Jun 27, 2019

Adjusting TaskManager FifoSet with the style of ProtocolHandler constructor.

@shargon, since #872 did not look good, this might be the way for keeping the standard.

Adjusting TaskManager FifoSet with the style of ProtocolHandler constructor
@vncoelho vncoelho requested a review from shargon June 27, 2019 17:00
@codecov-io
Copy link

codecov-io commented Jun 27, 2019

Codecov Report

Merging #876 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #876      +/-   ##
==========================================
- Coverage   43.56%   43.56%   -0.01%     
==========================================
  Files         177      177              
  Lines       12578    12577       -1     
==========================================
- Hits         5480     5479       -1     
  Misses       7098     7098
Impacted Files Coverage Δ
neo/Network/P2P/TaskManager.cs 18.99% <100%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d664be6...76d6f34. Read the comment docs.

@vncoelho vncoelho merged commit a9d0a1f into master Jun 27, 2019
@vncoelho vncoelho deleted the adjusting-fifoset-taskman-init branch June 27, 2019 17:38
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
Tommo-L pushed a commit to Tommo-L/neo that referenced this pull request Jun 22, 2020
Adjusting TaskManager FifoSet with the style of ProtocolHandler constructor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants