Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IPolicyPlugin #971

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Remove IPolicyPlugin #971

merged 1 commit into from
Jul 31, 2019

Conversation

erikzhang
Copy link
Member

@erikzhang erikzhang commented Jul 31, 2019 •
edited
Loading

Closes #963

@erikzhang erikzhang added this to the NEO 3.0 milestone Jul 31, 2019
vncoelho
vncoelho reviewed Jul 31, 2019
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye bye, good friend. 💃
It has been good to see this as plugin, @erikzhang.

However, the Native contacts in outstanding in beauty and flexibility!

@vncoelho
Copy link
Member

closes #963

@vncoelho
Copy link
Member

closes neo-project/proposals#80

@codecov-io
Copy link

codecov-io commented Jul 31, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@cd99489). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #971   +/-   ##
=========================================
  Coverage          ?   53.77%           
=========================================
  Files             ?      194           
  Lines             ?    13250           
  Branches          ?        0           
=========================================
  Hits              ?     7125           
  Misses            ?     6125           
  Partials          ?        0
Impacted Files Coverage Δ
neo/Plugins/Plugin.cs 18.96% <ø> (ø)
neo/Consensus/ConsensusContext.cs 54.77% <0%> (ø)
neo/Consensus/ConsensusService.cs 15.7% <0%> (ø)
neo/Ledger/Blockchain.cs 37.5% <0%> (ø)
neo/SmartContract/Native/PolicyContract.cs 93.02% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd99489...4df699d. Read the comment docs.

igormcoelho
igormcoelho approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@igormcoelho igormcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, native policy now.

@shargon shargon merged commit 46ed67f into master Jul 31, 2019
@shargon shargon deleted the 3.0/remove-policy-plugin branch July 31, 2019 12:29
@erikzhang erikzhang removed this from the NEO 3.0 milestone Dec 6, 2019
Tommo-L pushed a commit to Tommo-L/neo that referenced this pull request Jun 22, 2020
@erikzhang @Tommo-L
Remove IPolicyPlugin (neo-project#971)
0f1bb13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vncoelho vncoelho vncoelho left review comments

@shargon shargon shargon approved these changes

@igormcoelho igormcoelho igormcoelho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove FilterForBlock & FilterForMemoryPool from plugins
5 participants
@erikzhang @vncoelho @codecov-io @igormcoelho @shargon