Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP5: is not clear/strong enough to be implemented reliably on the NEO platform. Needs updating #32

Closed
mwherman2000 opened this issue Mar 22, 2018 · 2 comments
Labels

Comments

@mwherman2000
Copy link
Contributor

mwherman2000 commented Mar 22, 2018

The NEP5 spec (https://github.com/neo-project/proposals/blob/master/nep-5.mediawiki) is unclear in its description of the intended NEP5 smart contract interfaces.

For example, it states that there is a Required and Optional set of methods that need to be implemented and that they need to be declared public. In addition, it doesn't mention any requirement for a Main method and it's parameters.

For example, the referenced example https://github.com/lllwvlvwlll/Woolong/blob/master/Woolong/Woolong.cs, declares these methods as private.

The specification needs to be corrected/updated. It's not strong enough to be implemented reliably on the NEO platform as it is written.

@mwherman2000
Copy link
Contributor Author

mwherman2000 commented Mar 23, 2018

Erik, the issue is more than a question. The specification isn't clear in terms of describing the intended NEP5 smart contract interfaces (and as a specification, it needs to be clear). I'll restate my original point.

@mwherman2000 mwherman2000 changed the title NEP5: Do the required methods have to be declared public per the current specification? NEP5: is not clear/strong enough to be implemented reliably on the NEO platform. Needs updating Mar 23, 2018
@mwherman2000
Copy link
Contributor Author

See my comments here: #33

This was referenced May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants