-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEP5: In C#.NEO, you can't have a method and an event with the same name (e.g. transfer
) as required in the specification
#33
Comments
The next line in the example is what I'm referring to: https://github.com/neo-project/examples-csharp/blob/master/ICO_Template/ICO_Template.cs#L29 doesn't conform to the specification or visa versa. The event is called |
The method name is not important and isn't specified in the spec as it is compiled away. Only the event name matters. |
The specification needs to say that - it needs to be reliable: accurate, clear, correct, and complete. It needs to be a document that can be given to:
The specification needs to be corrected/updated. It's not strong enough to be implemented reliably on the NEO platform as it is written. It needs to be a specification ...not a high-level guide. For example, https://github.com/neo-project/examples-csharp/blob/master/ICO_Template/ICO_Template.cs#L29, does not conform to the NEP5 specification as it is written today. |
NEP5 is really an interoperability specification between NEP5 smart contracts and wallets ...that's why it needs to reliable. |
The NEP5 spec (https://github.com/neo-project/proposals/blob/master/nep-5.mediawiki) states that there are to be a Required method and a Required event both called
transfer
. This isn't allowed in C#.NEO.The specification needs to be corrected/updated. It's not strong enough to be implemented reliably on the NEO platform as it is written.
The text was updated successfully, but these errors were encountered: