Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEP: NEO Executable Format (NEF) #121

Merged
merged 26 commits into from
Jul 29, 2021
Merged

NEP: NEO Executable Format (NEF) #121

merged 26 commits into from
Jul 29, 2021

Conversation

bettybao1209
Copy link
Contributor

close #120

shargon
shargon reviewed Mar 31, 2020
View reviewed changes
nep-16.mediawiki Outdated Show resolved Hide resolved
vncoelho
vncoelho reviewed Mar 31, 2020
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @bettybao1209, nice writting and definition.

vncoelho
vncoelho reviewed Mar 31, 2020
View reviewed changes
nep-16.mediawiki Outdated Show resolved Hide resolved
@erikzhang erikzhang changed the title NEP: NeoContract NEF NEP: NEO Executable Format (NEF) Apr 1, 2020
ixje
ixje suggested changes May 21, 2020
View reviewed changes
Copy link
Contributor

@ixje ixje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This NEP describes a standard for how to store executable smart contract code that can be deployed. Given that NEO supports not just C# for writing contracts but also other languages the standard should provide sufficient information for other languages to create valid NEF files without having to look at the C# source code. The current revision provides too little information and relies heavily on knowing the C# source code. The below suggested changes should provide sufficient information such that alternative language implementers (like myself) do not require digging into the C# code.

nep-16.mediawiki Outdated Show resolved Hide resolved
nep-16.mediawiki Outdated Show resolved Hide resolved
nep-16.mediawiki Outdated Show resolved Hide resolved
nep-16.mediawiki Outdated Show resolved Hide resolved
nep-16.mediawiki Outdated Show resolved Hide resolved
nep-16.mediawiki Outdated Show resolved Hide resolved
@shargon @ixje
Update nep-16.mediawiki
272e194 
Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>
@ixje
Copy link
Contributor

ixje commented May 25, 2020

@shargon I see you accepted only one suggestion. Do you have any feedback on the other ones?

shargon and others added 5 commits May 25, 2020 09:49
@shargon @ixje
Update nep-16.mediawiki
0ec792a 
Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>
@shargon @ixje
Update nep-16.mediawiki
eb8ba12 
Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>
@shargon @ixje
Update nep-16.mediawiki
d49afea 
Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>
@shargon @ixje
Update nep-16.mediawiki
025fc0e 
Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>
@shargon @ixje
Update nep-16.mediawiki
5831566 
Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>
@shargon
Copy link
Member

shargon commented May 25, 2020

Maybe we can add this table

https://github.com/neo-project/neo/blob/425dbd54b8f510f1eb7f76df75c2b42947cd91e1/src/neo/SmartContract/NefFile.cs#L9-L20

ixje
ixje suggested changes May 25, 2020
View reviewed changes
Copy link
Contributor

@ixje ixje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix to hyperlink format for mediawiki

nep-16.mediawiki Outdated Show resolved Hide resolved
@shargon @ixje
Update nep-16.mediawiki
36d0ab2 
Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>
shargon
shargon reviewed Jul 6, 2020
View reviewed changes
nep-16.mediawiki Outdated Show resolved Hide resolved
@erikzhang @shargon
Update nep-16.mediawiki
c885abf 
Co-authored-by: Shargon <shargon@gmail.com>
shargon
shargon previously approved these changes Jul 6, 2020
View reviewed changes
ixje
ixje reviewed Jul 6, 2020
View reviewed changes
nep-16.mediawiki Outdated Show resolved Hide resolved
@shargon @ixje
Update nep-16.mediawiki
55527b6 
Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>
shargon
shargon previously approved these changes Jul 6, 2020
View reviewed changes
shargon
shargon reviewed Sep 25, 2020
View reviewed changes
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scripthash was replaced by Abi, could you update this PR @bettybao1209 ? neo-project/neo#1973

@shargon shargon mentioned this pull request Sep 25, 2020
Closed
@bettybao1209 bettybao1209 reopened this Nov 11, 2020
roman-khimov
roman-khimov reviewed Nov 12, 2020
View reviewed changes
nep-16.mediawiki Outdated Show resolved Hide resolved
@Tommo-L
Copy link

Tommo-L commented Nov 19, 2020

Need to be updated, related to neo-project/neo#2044

@superboyiii
Copy link
Member

@erikzhang @bettybao1209 Let's move on?

erikzhang
erikzhang requested changes Jan 5, 2021
View reviewed changes
nep-16.mediawiki Outdated Show resolved Hide resolved
@erikzhang
Copy link
Member

Please add method tokens.

@bettybao1209
Copy link
Contributor Author

Please add method tokens.

Ok, I'm working on it.

erikzhang
erikzhang reviewed Jan 14, 2021
View reviewed changes
nep-16.mediawiki Outdated Show resolved Hide resolved
erikzhang
erikzhang reviewed Jan 14, 2021
View reviewed changes
nep-16.mediawiki Outdated Show resolved Hide resolved
nep-16.mediawiki Outdated Show resolved Hide resolved
@gsmachado
Copy link

The same comment that I mentioned here applies to this NEP.

I've made an addition here: https://github.com/neo-project/proposals/pull/121/files#r557413256

It would be good if someone could accept or reject.

😄

erikzhang and others added 2 commits January 14, 2021 22:07
@erikzhang @gsmachado
Update nep-16.mediawiki
998a75e 
Co-authored-by: Guil. Sperb Machado <gsm@machados.org>
@bettybao1209
format and author adjuct
2de58a2
@erikzhang erikzhang mentioned this pull request Jan 15, 2021
Merged
@erikzhang
Copy link
Member

Merge?

shargon
shargon previously approved these changes Apr 17, 2021
View reviewed changes
@erikzhang erikzhang merged commit 978c3d9 into neo-project:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov left review comments

@vncoelho vncoelho vncoelho left review comments

@ixje ixje ixje requested changes

@gsmachado gsmachado gsmachado left review comments

@igormcoelho igormcoelho igormcoelho left review comments

@erikzhang erikzhang erikzhang approved these changes

@shargon shargon shargon left review comments

Assignees
No one assigned
Labels
accepted NEP-Standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NEP?: Script Nef Standard
10 participants
@bettybao1209 @ixje @shargon @Tommo-L @superboyiii @erikzhang @gsmachado @igormcoelho @vncoelho @roman-khimov