-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix connection acquisition timeout #504
Conversation
When the driver is performing routing, the connection acquisition for a connection to the router should also be affected by the connection acquisition timeout. However, it should have its own timeout because it's a separate acquisition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⏲️ 💣
self._start_server(self._router, "router_hello_delay.script") | ||
self._start_server(self._server, "session_run.script") | ||
self._start_server(self._server, "session_run_auth_delay.script") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you need to add delay to the session run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I want to make sure that the connection_acquisition_timeout_ms (6000ms
) counts for each connection acquisition separately. So even though the total delay (4s during router handshake, 4s during reader handshake) exceeds the set timeout, it should still work because the individual delays are below the timeout.
The driver was behaving correctly. The TestKit tests were adjusted: neo4j-drivers/testkit#504 Hence, the skip can be removed.
The driver was behaving correctly. The TestKit tests were adjusted: neo4j-drivers/testkit#504 Hence, the skip can be removed.
When the driver is performing routing, the connection acquisition for a
connection to the router should also be affected by the connection acquisition
timeout. However, it should have its own timeout because it's a separate
acquisition.
Depends on: