Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown tables not rendered #836

Open
mariusconjeaud opened this issue Mar 20, 2024 · 3 comments · Fixed by #893
Open

Markdown tables not rendered #836

mariusconjeaud opened this issue Mar 20, 2024 · 3 comments · Fixed by #893
Labels
enhancement New feature or request

Comments

@mariusconjeaud
Copy link
Collaborator

  • NeoDash version: 2.4.4

The following Markdown table is valid, but does not get rendered properly in Markdown report

As of: 2024-03-13T13:28:44
Summary
Items 227
Codelists 65
Units 4
image
@mariusconjeaud mariusconjeaud added the bug Something isn't working label Mar 20, 2024
@nielsdejong nielsdejong added the help wanted Extra attention is needed label Apr 8, 2024
@m-crown
Copy link

m-crown commented Apr 12, 2024

From what I understand , neodash uses react-markdown, and table rendering is part of the github flavoured markdown that needs to be specifically enabled - if so I'm not sure this is a bug , but it would be a really great feature to add!

@mariusconjeaud
Copy link
Collaborator Author

This is indeed not a bug, you are right.

@mariusconjeaud mariusconjeaud added enhancement New feature or request and removed bug Something isn't working labels Apr 29, 2024
mariusconjeaud pushed a commit that referenced this issue May 14, 2024
@mariusconjeaud
Copy link
Collaborator Author

See open PR (note the a tag is here is sanitized by the component, and displayed as a string by the Markdown component on purpose, for security reasons)

image

@mariusconjeaud mariusconjeaud linked a pull request May 14, 2024 that will close this issue
@mariusconjeaud mariusconjeaud added Ready To Merge and removed help wanted Extra attention is needed labels May 14, 2024
nielsdejong pushed a commit that referenced this issue Nov 11, 2024
Co-authored-by: Marius Conjeaud <rmcj@novonordisk.com>
@nielsdejong nielsdejong removed the 2.4.9 label Nov 14, 2024
nielsdejong added a commit that referenced this issue Nov 14, 2024
* Bump es5-ext from 0.10.62 to 0.10.64

Bumps [es5-ext](https://github.com/medikoo/es5-ext) from 0.10.62 to 0.10.64.
- [Release notes](https://github.com/medikoo/es5-ext/releases)
- [Changelog](https://github.com/medikoo/es5-ext/blob/main/CHANGELOG.md)
- [Commits](medikoo/es5-ext@v0.10.62...v0.10.64)

---
updated-dependencies:
- dependency-name: es5-ext
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Disable form button until all parameters in given

* fix: check empty string as well

* Bump webpack-dev-middleware from 5.3.3 to 5.3.4

Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4.
- [Release notes](https://github.com/webpack/webpack-dev-middleware/releases)
- [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md)
- [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4)

---
updated-dependencies:
- dependency-name: webpack-dev-middleware
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /gallery

Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4.
- [Release notes](https://github.com/webpack/webpack-dev-middleware/releases)
- [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md)
- [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4)

---
updated-dependencies:
- dependency-name: webpack-dev-middleware
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump express from 4.18.1 to 4.19.2 in /docs

Bumps [express](https://github.com/expressjs/express) from 4.18.1 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.1...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump express from 4.18.2 to 4.19.2 in /gallery

Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump express from 4.18.2 to 4.19.2

Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* added cypress

* Added cypress

* Add a dependabot config file

* Add docs directory to dependabot

* Fix dependabot yarn to npm

* Migrate DataGrid to 7.x #850 ; Initial changes

* Fix compact x wrapping

* feat: Updated JSDoc

* Bump micromatch from 4.0.5 to 4.0.8 in /gallery (#948)

Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8.
- [Release notes](https://github.com/micromatch/micromatch/releases)
- [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/micromatch@4.0.5...4.0.8)

---
updated-dependencies:
- dependency-name: micromatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Bump webpack from 5.77.0 to 5.94.0 (#947)

Bumps [webpack](https://github.com/webpack/webpack) from 5.77.0 to 5.94.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.77.0...v5.94.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump fast-loops from 1.1.3 to 1.1.4 in /gallery (#920)

Bumps [fast-loops](https://github.com/robinweser/fast-loops) from 1.1.3 to 1.1.4.
- [Commits](https://github.com/robinweser/fast-loops/commits)

---
updated-dependencies:
- dependency-name: fast-loops
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ws from 8.12.1 to 8.17.1 (#911)

Bumps [ws](https://github.com/websockets/ws) from 8.12.1 to 8.17.1.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.12.1...8.17.1)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump braces from 3.0.2 to 3.0.3 in /gallery (#908)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Bump follow-redirects from 1.15.4 to 1.15.6 in /gallery (#831)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump follow-redirects from 1.15.4 to 1.15.6 (#830)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Added evolution notice

* Fixed typo in README

* Fixed typo in README

* Bumped version number to 2.4.9

* Improve method for checking "low" property existence in downloadCSV function (#951)

Co-authored-by: “Bastien <“bastien.hubert@hotmail.com”>

* Update configuration.adoc (#946)

Default loggingDatabase is logs not neo4j, updated same in document.

Issue Closed : #915

Document Referred : 
https://github.com/neo4j-labs/neodash/blob/42b196a3ec9a1d5740e4c81420a762646b1295b7/scripts/config-entrypoint.sh#L26
https://neo4j.com/labs/neodash/2.4/developer-guide/configuration/#_configuration_options

Signed-off-by: Singh, Jyotsana <Jyotsana.Singh@fmr.com>

* Feature/rule based styling table colouring (#944)

* rule based styling cell colouring feature

* changing cell text/background colour now plays nicely

* TODO note about row/cell rule mix and match behaviour

* Bugfix/array table wrap (#943)

* table wrap bug fix

* typo fix

* changes to add ssl support (#935)

Signed-off-by: Parekh, Geet <geet.parekh@fmr.com>

* adding param to manage SSO redirection (#918)

* adding param to manage SSO redirection

* added standalone when not sharing credentials

* Removed superfluous log statements

---------

Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Add possibility to hide Y axes and grid lines in BarChart (#895)

* Add possibility to hide Y axes and grid lines in BarChart

* Add Husky prepare stage

* Fix stacked grouped function test

* Fix pie chart e2e test in start_page.cy

* Add Bar chart Y axis e2e tests

* Add Cypress support in eslintrc.json

* Create Page helper class for Cypress

* Update browserlist

* Fix e2e bar tests by removing within

---------

Co-authored-by: “Bastien <“bastien.hubert@hotmail.com”>
Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Markdown tables not rendered #836 (#893)

Co-authored-by: Marius Conjeaud <rmcj@novonordisk.com>

* Added banner to all docs pages referring to new docs

* Updated README

* Current Users or ALL Users getting deleted in an Update (#906)

* fixed: when updating a user permission by DELETING a user from a certain role, it drops ALL the users. Also if you add a user to a role it will still keep the role on previously added users

* updated the code so that if datbase selected is empty we show feedback there is nothing to fetch and do not provide labels and also enable to save users to role even though db is empty

---------

Co-authored-by: Niels de Jong <Niels-121@hotmail.com>

* Finalized release notes and updated README for 2.4.9

* [Feature #884] Helm chart for Kubernetes deployments PR#902 (#971)

* Include the Helm Chart and Kubernetes YAMLs

- Includes the Helm chart required for the NeoDash deployment for the
  Kubernetes clusters
- Includes the example YAML files for the Kubernetes manifests
- Appropriate document changes to include the new Kubernetes
  deployments.

Signed-off-by: Lolla, Venkata <venkata.lolla@fMR.COM>

* Fix the chart notes

Signed-off-by: Lolla, Venkata <venkata.lolla@fMR.COM>

* Patch a typo in the build-and-run.adoc file

Signed-off-by: Lolla, Venkata <venkata.lolla@fMR.COM>

* Resolves SonarCloud warning

Signed-off-by: Lolla, Venkata <venkata.lolla@fMR.COM>

* Review + small fixes, LGTM

---------

Signed-off-by: Lolla, Venkata <venkata.lolla@fMR.COM>
Co-authored-by: Lolla, Venkata <venkata.lolla@fMR.COM>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Singh, Jyotsana <Jyotsana.Singh@fmr.com>
Signed-off-by: Parekh, Geet <geet.parekh@fmr.com>
Signed-off-by: Lolla, Venkata <venkata.lolla@fMR.COM>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Monish <139316519+m-o-n-i-s-h@users.noreply.github.com>
Co-authored-by: Marius Conjeaud <rmcj@novonordisk.com>
Co-authored-by: MariusC <marius.conjeaud@outlook.com>
Co-authored-by: Bastien Hubert <43408420+bastienhubert@users.noreply.github.com>
Co-authored-by: “Bastien <“bastien.hubert@hotmail.com”>
Co-authored-by: JyotsanaSingh <62237566+Jyots6914@users.noreply.github.com>
Co-authored-by: LiamEdwardsLamarche <134382136+LiamEdwardsLamarche@users.noreply.github.com>
Co-authored-by: geetparekh <geetparekh@gmail.com>
Co-authored-by: alfredorubin96 <103421036+alfredorubin96@users.noreply.github.com>
Co-authored-by: Aleksandar <aleksandar.simeunovic94@gmail.com>
Co-authored-by: Morgan Senechal <morgan@neo4j.com>
Co-authored-by: Lolla, Venkata <venkata.lolla@fMR.COM>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants