Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - customize pie chart legend #762

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Feature - customize pie chart legend #762

wants to merge 5 commits into from

Conversation

jbleakleycode
Copy link
Contributor

Added vertical and horizontal legend setting which sets legend to the right or to the bottom.

@jbleakleycode
Copy link
Contributor Author

Still needs documentation updated

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

7.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@jbleakleycode jbleakleycode linked an issue Jan 19, 2024 that may be closed by this pull request
Add customization options for pie chart legend #748
Open
@nielsdejong nielsdejong changed the base branch from master to develop February 21, 2024 13:04
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nielsdejong
Copy link
Collaborator

@jacobbleakley-neo4j
Code looks good, I added docs and did some small style fixes.
It seems however that the legend isn't working properly.

I created a simple report:

UNWIND range(1,7) as X
RETURN 'a'+X as cat,rand() as nbr

And toggled 'show legend' to on. Nothing shows on the screen however with these default settings:
image

Can you take a look?

nielsdejong
nielsdejong requested changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@nielsdejong nielsdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in PR conversation

@nielsdejong nielsdejong removed the 2.4.3 label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdejong nielsdejong nielsdejong requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add customization options for pie chart legend
2 participants
@jbleakleycode @nielsdejong