Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/table export #781

Merged
merged 8 commits into from
Feb 22, 2024
Merged

Fix/table export #781

merged 8 commits into from
Feb 22, 2024

Conversation

alfredorubin96
Copy link
Collaborator

Fixing the following problems:

  1. fixing comma escaping for each value in the export
  2. added utf-8 charset to exported CSV

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (20e4e0a) 39.07% compared to head (417f4bd) 38.81%.
Report is 85 commits behind head on develop.

Files Patch % Lines
src/chart/ChartUtils.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #781      +/-   ##
===========================================
- Coverage    39.07%   38.81%   -0.27%     
===========================================
  Files          208      211       +3     
  Lines         8721     8837     +116     
  Branches      2598     2637      +39     
===========================================
+ Hits          3408     3430      +22     
- Misses        5252     5346      +94     
  Partials        61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nielsdejong nielsdejong merged commit c77eee4 into develop Feb 22, 2024
2 of 4 checks passed
@alfredorubin96 alfredorubin96 deleted the fix/table-export branch February 22, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to export table CSVs with correctly escaped characters
2 participants