Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/parameter select #794

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Fix/parameter select #794

merged 7 commits into from
Feb 28, 2024

Conversation

alfredorubin96
Copy link
Collaborator

FIxing:

  1. When initialising the selector in multi mode, it was pushing also an empty string in the list of values
  2. when clearing the list, the values weren't casted to string

… and input.toLowerCase is not a function error
@alfredorubin96 alfredorubin96 changed the base branch from master to develop February 26, 2024 18:14
@alfredorubin96 alfredorubin96 linked an issue Feb 26, 2024 that may be closed by this pull request
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 38.55%. Comparing base (20e4e0a) to head (9dcb8a2).
Report is 94 commits behind head on develop.

Files Patch % Lines
...arameter/component/NodePropertyParameterSelect.tsx 37.50% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #794      +/-   ##
===========================================
- Coverage    39.07%   38.55%   -0.53%     
===========================================
  Files          208      211       +3     
  Lines         8721     8858     +137     
  Branches      2598     2644      +46     
===========================================
+ Hits          3408     3415       +7     
- Misses        5252     5385     +133     
+ Partials        61       58       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nielsdejong nielsdejong merged commit 6b1379b into develop Feb 28, 2024
2 of 4 checks passed
@alfredorubin96 alfredorubin96 deleted the fix/parameter-select branch February 28, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants