-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed jvm.additional overriden by docker-entrypoint #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and if the tests pass I approve.
I do wonder if we have the same problem with NEO4J_wrapper_java_additional
?
I think we have the same problem with it also,I will fix it. Thanks. |
…ditional-not-overriden
Found a new more reliable way to fix it that also includes the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good! I only have a minor edit request.
@@ -368,6 +365,16 @@ for conf in ${!ENTERPRISE[@]} ; do | |||
fi | |||
done | |||
|
|||
if grep -q "udc.source=tarball" "${NEO4J_HOME}"/conf/neo4j.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment applies to all entrypoints.
I've a couple of notes about making this easier for us to maintain.
-
In general if you're doing something in your which looks crazy, it's a good idea to leave a comment as to why you're doing it that way instead of another way. This is because when you come back to your code in 6 months time, you don't waste a load of time wondering whyyyy you did this crazy looking thing (and usually reaching the same conclusion you did originally). What I'm saying is write a comment here about why you're using sed/grep to edit the conf :)
-
Could you make the indentation consistent? It's easier to read that way, and extra indentation makes me worry that some code got deleted around this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
dbms.jvm.additional
were being overriden bydocker-entrypoint.sh
.