use new 'neo4j dry-run' mechanism to start neo4j process in 4.3 #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennyowen
approved these changes
May 20, 2021
|
We're reasonably sure that this should not be merged until drop-04 has been accepted |
|
@Roxling requests that we check what happens if the
|
added 4 commits
May 20, 2021 20:59
do not run as root change neo4j dry-run from a command to an argument. Minor tidying of the script
jennyowen
pushed a commit
that referenced
this pull request
Nov 3, 2022
* use new 'neo4j dry-run' mechanism to start neo4j process in 4.3 do not run as root change neo4j dry-run from a command to an argument. Minor tidying of the script * reduce use of eval * Revert "temporarily revert tests for command expansion bugs because those bugs are present but tolerated in drop04 (#297)" This reverts commit a6d7eda. * handle errors from --dry-run correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
n.b. takes care not to run neo4j as root