Fixed setting config values via environment values #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For values which had old hardcoded versions we would always override the new kind. If the old variable had no value then we wrote that empty value. * Now only sets the values conditionally: if no value for the new kind of variable exists, and then only if the previous variable has a value. And if not, then we write whatever is the default (or nothing).
spacecowboy
force-pushed
the
fix-env-config
branch
from
15ad794
to
1e3b34b
Compare
srbaker
added a commit
to neo4j/docker-neo4j-publish
that referenced
this pull request
Jun 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the new kind. If the old variable had no value then we wrote that
empty value.
of variable exists, and then only if the previous variable has a
value. And if not, then we write whatever is the default (or nothing).