Fix the code example #228
Merged
Fix the code example #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
parnmatt
reviewed
Nov 5, 2024
| ArrayList<Relationship> filtered = new ArrayList<>(); | ||
| for ( Relationship relationship : relationships ) { | ||
| if ( branchState.getState() + (double) relationship.getProperty( "weight" ) <= maxWeight ) { | ||
| filtered.add(relationship); | ||
| } | ||
| } | ||
| return filtered; | ||
| return Iterables.asResourceIterable(filtered); |
There was a problem hiding this comment.
I've accepted the change, though it does use an internal method (Iterables utility class is not part of the public api)
We don't have an alternative currently that I am aware of, other than the user writing their own wrapper.
There was a problem hiding this comment.
I believe we have informed customers who do use the traversal framework to use this method in the past.
parnmatt
approved these changes
Nov 5, 2024
gem-neo4j
approved these changes
Nov 5, 2024
NataliaIvakina
added a commit
to NataliaIvakina/docs-java-reference
that referenced
this pull request
Nov 5, 2024
NataliaIvakina
added a commit
that referenced
this pull request
Nov 5, 2024
NataliaIvakina
added a commit
that referenced
this pull request
Dec 9, 2024
* bump dev to 5.21 (#205) * Replacing underscores with hyphens for crawlability (#206) * Bump Neo4j version to 5.22 and driver v to 5.23 (#208) * Update `dev` to 5.23 (#213) * Bump version number to 5.24 (#215) * Update preview version to 5.25 (#220) * Add documentation for user procedure memory resource tracking * Bump the Neo4j v.n. to 5.25 and the Java driver to 5.26.1 (#227) * Bump express in the dev-dependencies group across 1 directory (#224) Bumps the dev-dependencies group with 1 update in the / directory: [express](https://github.com/expressjs/express). Updates `express` from 4.19.1 to 4.21.1 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.1/History.md) - [Commits](expressjs/express@4.19.1...4.21.1) --- updated-dependencies: - dependency-name: express dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix the code example (#228) * Update setup.adoc (#222) (#230) gradle "compile" deprecated in version 7.x - replaced by "implementation." Correcting. Co-authored-by: Q | Andrew Righter <153233436+q-at-cyberdelia@users.noreply.github.com> * Introduce DatabaseSeedProvider and deprecated SeedProvider * Update modules/ROOT/pages/extending-neo4j/project-setup.adoc Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com> * Update modules/ROOT/pages/extending-neo4j/project-setup.adoc Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com> * Update modules/ROOT/pages/extending-neo4j/project-setup.adoc Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com> * Update modules/ROOT/pages/extending-neo4j/project-setup.adoc Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com> * Update modules/ROOT/pages/extending-neo4j/project-setup.adoc Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com> * Update modules/ROOT/pages/extending-neo4j/project-setup.adoc Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com> * Update modules/ROOT/pages/extending-neo4j/project-setup.adoc Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com> * Update driver version (#234) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Jessica Wright <49636617+AlexicaWright@users.noreply.github.com> Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> Co-authored-by: Reneta Popova <reneta.popova@neo4j.com> Co-authored-by: Love Kristofer Leifland <love.leifland@neotechnology.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Q | Andrew Righter <153233436+q-at-cyberdelia@users.noreply.github.com> Co-authored-by: Jack Waudby <jack.waudby@neo4j.com> Co-authored-by: Jack Waudby <33488812+jackwaudby@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.