Skip to content

Cypher25 default language #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: cypher-25
Choose a base branch
from

Conversation

renetapopova
Copy link
Collaborator

Replaces #2153

Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only got started on the review, have looked at 11/21 files and have all the big ones left. But figured I'd post the comments I have so far as I'm pausing for the day.

Status: 3 open comments

renetapopova and others added 3 commits June 2, 2025 15:49
…adoc

Co-authored-by: Therese Magnusson <scout.therese@gmail.com>
…adoc

Co-authored-by: Therese Magnusson <scout.therese@gmail.com>
…adoc

Co-authored-by: Therese Magnusson <scout.therese@gmail.com>
Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have 2 files left to look at, the privilege file (how did you get over 700 lines changed from our 90 something on the previous PR? XD) and the manage aliases for standard database file (only like 200 more lines changed than the previous PR :P)

Status: 5 open comments

Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of alias page

Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started on the privilege file updates

@@ -653,16 +682,18 @@ A user that is granted the `SET USER STATUS` privilege is allowed to run the `AL
ALTER USER jake SET STATUS ACTIVE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not changing the info line above this example?

A user that is granted the `SET USER STATUS` privilege is allowed to run the `ALTER USER` administration command with only the `SET STATUS` part:

vs

The `SET USER STATUS` privilege allows the user to run the `ALTER USER` administration command with only the `SET STATUS` part.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is changed on line 723. I am not sure I understand what you mean here.

The resulting role has privileges that only allow modifying the home database of users.
List all privileges for the role `statusModifier` as commands by using the following query:
As a result, the `statusModifier` role has privileges that only allow modifying the home database of users.
To list all privileges for the role `statusModifier` as commands, use the following query:

[source, cypher, role=noplay]
----
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more missed updates below

A user that is granted the `SET USER HOME DATABASE` privilege is allowed to run the `ALTER USER` administration command with only the `SET HOME DATABASE` or `REMOVE HOME DATABASE` part:

vs

The `SET USER HOME DATABASE` privilege allows the user to run the `ALTER USER` administration command with only the `SET HOME DATABASE` or `REMOVE HOME DATABASE` part.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is below one line757.

renetapopova and others added 4 commits June 10, 2025 15:21
…ses-composite-databases.adoc

Co-authored-by: Therese Magnusson <scout.therese@gmail.com>
…create-databases.adoc

Co-authored-by: Therese Magnusson <scout.therese@gmail.com>
…start-stop-databases.adoc

Co-authored-by: Therese Magnusson <scout.therese@gmail.com>
…ation.adoc

Co-authored-by: Therese Magnusson <scout.therese@gmail.com>
Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next chunk of the privilege file updates

@@ -1106,14 +1223,7 @@ a|Rows: 1
[[access-control-dbms-administration-alias-management]]
== The DBMS `ALIAS MANAGEMENT` privileges

The DBMS privileges for alias management can be assigned by using Cypher administrative commands and can be applied to both local and remote aliases.
They can be granted, denied and revoked like other privileges.
It is also possible to manage aliases with <<access-control-dbms-administration-database-management, database management commands>>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NataliaIvakina this one too

Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got through the file, now everything have been looked at once

@renetapopova
Copy link
Collaborator Author

renetapopova commented Jun 24, 2025

@Hunterness, could you please check where it should be SET DEFAULT LANGUAGE CYPHER {5|25}, [SET DEFAULT LANGUAGE CYPHER {5|25}], [DEFAULT LANGUAGE CYPHER {5|25}], DEFAULT LANGUAGE CYPHER {5|25}? I think they are inconsistent across Cypher 5 and Cypher 25, as well as across commands.

@mnd999
Copy link
Contributor

mnd999 commented Jun 24, 2025

@renetapopova just checking, you do know that SET DEFAULT LANGUAGE is also in Cypher 5?

@renetapopova
Copy link
Collaborator Author

@renetapopova just checking, you do know that SET DEFAULT LANGUAGE is also in Cypher 5?

Is this a question to my question above or separate?

@renetapopova
Copy link
Collaborator Author

In some places, it is with SET, in some without. Sometimes, it's optional, and sometimes, it's not. Hence, my question above.

@mnd999
Copy link
Contributor

mnd999 commented Jun 24, 2025

@renetapopova separate. I haven't been able to find the Cypher 5 docs for the release, and tracking the PR history is quite tricky. I want to make sure we documented SET DEFAULT LANGUAGE in both language versions.

From looking at the parser, SET is mandatory on ALTER DATABASE, and from Cypher 25 optional on CREATE DATABASE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants