Images refresh batch 2 #2541

lidiazuin · 2025-08-15T11:50:17Z

No description provided.

…neo4j#2490) Since we moved them over from DBMS level (while still keeping the DBMS level syntax, just as another syntax for `DATABASE *`) --------- Co-authored-by: Mark Dixon <1756429+mnd999@users.noreply.github.com> Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>

The Operations manual covers all releases of 2025.xx series. That's why we cannot simply replace examples with new ones, as new functionality has been added. We also need to retain examples for earlier versions of Neo4j.

modules/ROOT/images/privileges-hierarchy-database.svg

NataliaIvakina · 2025-08-28T09:12:35Z

On the page Database privileges, Figure 2. Syntax of GRANT and DENY database privileges is not updated.
Is this expected?

NataliaIvakina · 2025-08-28T09:15:16Z

On the page DBMS privileges, the Figure 1. Syntax of GRANT and DENY DBMS privileges is not updated.
The same question -- is this expected?

modules/ROOT/images/privileges-hierarchy-dbms.svg

NataliaIvakina · 2025-08-28T10:09:03Z

modules/ROOT/images/privileges-hierarchy-dbms.svg

I think, the branch (on the right hand side) for SERVER MANAGEMENT -> SHOW SERVERS, EXECUTE Privileges, and SHOW SETTINGS privilege is unclear and might be wrong.
There are three equal groups:

SERVER MANAGEMENT (with SHOW SERVERS at the 2nd level),

EXECUTE PRIVILEGES (that include EXECUTE PROCEDURES, EXECUTE BOOSTED PROCEDURES, EXECUTE ADMIN(ISTRATOR) PROCEDURES, EXECUTE FUNCTIONS, and EXECUTE BOOSTED FUNCTIONS),

and SHOW SETTINGS.

I think, we should have three equal branches for them. At the moment, their hierarchy is unclear.

The EXECUTE privileges aren't a group in the hierarchy: they don't have a common parent privilege.

They are included under ALL DBMS PRIVILEGES as that one includes EXECUTE FUNCTION, EXECUTE BOOSTED FUNCTION, EXECUTE PROCEDURE and EXECUTE BOOSTED PROCEDURE for all functions and procedures (which therefore also covers the EXECUTE ADMIN PROCEDURES as that one includes EXECUTE PROCEDURE and EXECUTE BOOSTED PROCEDURE but only for procedures marked as admin procedures). So the old image that currently exist in the documentation is correct to have them just on a line and not in a group, as the 'groups' are actual privileges themselves.

NataliaIvakina · 2025-08-28T10:17:10Z

modules/ROOT/images/privileges-hierarchy-dbms.svg

What if to make frames of the first level blocks bold? These blocks are:

ROLE MANAGEMENT

USER MANAGEMENT

IMPERSONATE

SERVER MANAGEMENT

DATABASE MANAGEMENT

ALIAS MANAGEMENT

PRIVILEGE MANAGEMENT

EXECUTE PRIVILEGES (I think they could be grouped together)

SHOW SETTINGS

NataliaIvakina · 2025-08-28T14:58:23Z

modules/ROOT/pages/authentication-authorization/dbms-administration.adoc

@@ -76,7 +76,7 @@ For more details on the differences between graphs, databases, and the DBMS, ref

 image::privileges_grant_and_deny_syntax_dbms_privileges.svg[width="800", title="Syntax of GRANT and DENY DBMS privileges"]


image::privileges-grant-and-deny-syntax-dbms-privileges.svg[width="800", title="Syntax of GRANT and DENY DBMS privileges"]

NataliaIvakina · 2025-08-28T15:04:03Z

modules/ROOT/pages/authentication-authorization/database-administration.adoc

@@ -480,7 +480,7 @@ GRANT [IMMUTABLE] TRANSACTION [MANAGEMENT] [( { * \| user[, ...] } )]
 |===


-image::privileges_grant_and_deny_syntax_database_privileges.svg[title="Syntax of GRANT and DENY Database Privileges"]
+image::privileges-grant-and-deny-syntax-database-privileges.svg[title="Syntax of GRANT and DENY Database Privileges", role=popup]


I don't understand what is happening here. In line 187, image::privileges_hierarchy_database.svg[title="Database privileges hierarchy"] is used instead of the new file name with hyphens. However, the new image is rendered in the preview.

The file name is updated in the line 483, but the old image is rendered.

Hunterness · 2025-08-29T13:02:07Z

modules/ROOT/images/privileges-hierarchy-dbms.svg

I feel like the blocks are hard to read and the hierarchy structure is harder to see with this layout :(

(I assume this applies to more than just this one of the hierarchy pictures but I only opened this one so far)

it looks better in the preview than here on github though 🤷

Hunterness · 2025-09-01T12:31:57Z

modules/ROOT/images/privileges-grant-and-deny-syntax-database-privileges.svg

this doesn't look like the latest version of this image, the development page version (https://development.neo4j.dev/docs/operations-manual/current/authentication-authorization/database-administration/) has some updates (regarding the four ALTER DATABASE privileges) that isn't reflected here

(nor are they in the hierarchy version)

renetapopova

Thank you, @lidiazuin. They all look good from a visual perspective but I've found some inconsistencies and things that might lead to misunderstandings.

renetapopova · 2025-09-08T11:05:54Z

modules/ROOT/images/privileges-hierarchy-database.svg

Alter database is missing

#2541 (comment) I also noticed this :P

modules/ROOT/pages/authentication-authorization/database-administration.adoc

renetapopova · 2025-09-08T11:17:31Z

modules/ROOT/images/privileges-grant-and-deny-syntax-dbms-privileges.svg

I think some of your image comments doesn't load?

renetapopova · 2025-09-08T11:48:07Z

modules/ROOT/images/privileges-hierarchy-dbms.svg

The connections that you noted that don't derive from the same place are all coming from ALL DBMS PRIVILEGES, that's the style of the arrows used in the technical diagrams. I can try to change the style, but just letting you know that this is the default styling.

I thought so, but they look misleading, so I decided to tell you if you can change them somehow.

modules/ROOT/pages/authentication-authorization/load-privileges.adoc

modules/ROOT/pages/authentication-authorization/dbms-administration.adoc

renetapopova · 2025-09-08T11:52:44Z

modules/ROOT/images/privileges-grant-and-deny-syntax-load-privileges.svg

There is no space between To role and [,...] in the original diagram. @Hunterness, is the space a problem?

I don't think it matters as such but generally I'd not have a space there if I write the command even if it parses (... TO role1, role2 vs ... TO role1 , role2) 🤷

I'll also say that if the other syntax images doesn't have the space I don't think we should have it here but be consistent about it

renetapopova · 2025-09-08T12:06:23Z

modules/ROOT/images/privileges-hierarchy.svg

Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>

Hunterness

Review of current state

Hunterness · 2025-09-10T14:02:41Z

modules/ROOT/images/privileges-grant-and-deny-syntax-database-privileges.svg

Missing the various ALTER DATABASE privileges (ALTER DATABASE, SET DATABASE ACCESS, SET DATABASE DEFAULT LANGUAGE, ALTER COMPOSITE DATABASE), and the *|name[, ...] after DATABASE[S] should not have any () as that isn't part of the syntax for the database part as it is for the user part after transactions.

Hunterness · 2025-09-10T14:13:34Z

modules/ROOT/images/privileges-grant-and-deny-syntax-dbms-privileges.svg

the database bubble looks empty, it should contain a lot of things not just alter database:

Hunterness · 2025-09-10T14:19:26Z

modules/ROOT/images/privileges-hierarchy-dbms.svg

The EXECUTE privileges are still not a group: the groups are existing privileges that also cover the sub-privileges and there isn't an EXECUTE privilege so it isn't a group

These hierarchy images are supposed to show the relationships between privileges and not just another way to show what privileges exist, so adding groupings that doesn't correspond to existing privileges are not valid

Hunterness · 2025-09-10T14:22:25Z

modules/ROOT/images/privileges-hierarchy-dbms.svg

ALTER USER is missing a line from USER MANAGEMENT

Also, the SET AUTH, SET USER HOME DATABASE, SET PASSWORD[S] and SET USER STATUS privileges are part of ALTER USER and not like here having set auth next to alter and the others as part of set auth

Hunterness · 2025-09-10T14:25:43Z

modules/ROOT/images/privileges-hierarchy-dbms.svg

Is there a black line through the ALL [DBMS [PRIVILEGE]] bubble? That seems weird and makes it harder to read

Hunterness · 2025-09-10T14:41:48Z

modules/ROOT/images/privileges-grant-and-deny-syntax-load-privileges.svg

This goes for all syntax images and not just load.

In our old pictures we marked keywords and input values differently, the keywords were in capital letters and the input was in italics and small letters, you still have the capital vs small letter diff but are missing the italics which helped separate them further

Unfortunately the font used now doesn't have an italic version... Is there another way we could point to that you think would be useful? For TO role[,...], for example, the bubble is white

Hunterness · 2025-09-10T14:45:09Z

modules/ROOT/pages/authentication-authorization/manage-privileges.adoc

@@ -210,7 +210,7 @@ image::privileges_on_graph_syntax.svg[width="800", title="Syntax of GRANT and DE

 The following image shows the hierarchy between different graph privileges:

-image::privileges_hierarchy.svg[title="Graph privileges hierarchy"]
+image::privileges-hierarchy.svg[title="Graph privileges hierarchy", role=popup]


so you update this one but not the two above?

image::privileges_grant_and_deny_syntax.svg[width="800", title="GRANT and DENY Syntax"] image::privileges_on_graph_syntax.svg[width="800", title="Syntax of GRANT and DENY Graph Privileges. The `{` and `}` are part of the syntax and not used for grouping."]

Hunterness · 2025-09-10T14:46:36Z

modules/ROOT/images/privileges-hierarchy.svg

I like that this one have arrows, I'd like the other hierarchy ones to also have that

Hunterness · 2025-09-10T14:47:52Z

modules/ROOT/images/privileges-hierarchy.svg

Missing a line from MERGE to MATCH

Also, to me having SET PROPERTY be in the middle layer feels odd, hierarchy-wise it's on the same level as for example CREATE (two steps away from the top ALL [GRAPH [PRIVILEGES]] one) so putting it on the level with the MATCH/MERGE/WRITE that is one step from the top feels odd.

But it does avoid having to have lines crossing each other 🤷

Hunterness · 2025-09-10T14:51:53Z

modules/ROOT/pages/kubernetes/quickstart-standalone/server-setup.adoc

@@ -27,5 +27,4 @@ Then, the Neo4j Helm chart creates Kubernetes entities needed for running and ac
 The following diagram is a schematic representation of the Helm chart involved and the Kubernetes and Cloud resources it instantiates when installed:

 .Neo4j standalone setup
-image::standalone-on-k8s.svg[Example of Neo4j standalone setup in Kubernetes,width=700,role=popup]
-
+image::standalone-on-k8s.svg[Example of Neo4j standalone setup in Kubernetes,width=700,role=popup]


I don't think this finds the image

neo4j-docops-agent · 2025-09-11T12:58:40Z

This PR includes documentation updates
View the updated docs at https://neo4j-docs-operations-2541.surge.sh

Updated pages:

Images refresh batch 2

399a3a6

lidiazuin requested review from renetapopova and NataliaIvakina August 15, 2025 11:50

lidiazuin added the cherry-pick-this-to-main label Aug 15, 2025

lidiazuin and others added 6 commits August 15, 2025 13:50

Merge branch 'dev' into imgrefresh-batch2

86a6ef6

Update the description of the history option (neo4j#2543)

fc82a2d

Add tabbed examples for multiple node IDs (neo4j#2512)

fe668fb

The Operations manual covers all releases of 2025.xx series. That's why we cannot simply replace examples with new ones, as new functionality has been added. We also need to retain examples for earlier versions of Neo4j.

Images refresh batch 2

879932c

Merge branch 'dev' into imgrefresh-batch2

bfb7692

NataliaIvakina reviewed Aug 28, 2025

View reviewed changes

modules/ROOT/images/privileges-hierarchy-database.svg Outdated Show resolved Hide resolved

NataliaIvakina reviewed Aug 28, 2025

View reviewed changes

modules/ROOT/images/privileges-hierarchy-dbms.svg Outdated Show resolved Hide resolved

NataliaIvakina reviewed Aug 28, 2025

View reviewed changes

modules/ROOT/images/privileges-hierarchy-dbms.svg Outdated Show resolved Hide resolved

NataliaIvakina reviewed Aug 28, 2025

View reviewed changes

reviewed images after feedback

3a9c6f0

NataliaIvakina reviewed Aug 28, 2025

View reviewed changes

review after feedback

ed698cb

Hunterness reviewed Aug 29, 2025

View reviewed changes

Hunterness reviewed Sep 1, 2025

View reviewed changes

lidiazuin and others added 3 commits September 1, 2025 15:47

Merge branch 'dev' into imgrefresh-batch2

41136da

update of image

50c621f

update image after review

dbb011c

renetapopova requested changes Sep 8, 2025

View reviewed changes

lidiazuin and others added 3 commits September 10, 2025 15:10

first updates after review (more to come)

c8dd59e

Merge branch 'dev' into imgrefresh-batch2

f11978f

Apply suggestions from code review

1da63da

Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>

lidiazuin requested review from renetapopova and Hunterness September 10, 2025 13:14

Hunterness reviewed Sep 10, 2025

View reviewed changes

updated images after review

73f9704

		@@ -76,7 +76,7 @@ For more details on the differences between graphs, databases, and the DBMS, ref

		image::privileges_grant_and_deny_syntax_dbms_privileges.svg[width="800", title="Syntax of GRANT and DENY DBMS privileges"]

Images refresh batch 2 #2541

Are you sure you want to change the base?

Images refresh batch 2 #2541

Uh oh!

Conversation

lidiazuin commented Aug 15, 2025

Uh oh!

Uh oh!

NataliaIvakina commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NataliaIvakina commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NataliaIvakina Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NataliaIvakina Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Hunterness Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

renetapopova left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

renetapopova Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

renetapopova Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

renetapopova Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Hunterness left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

NataliaIvakina commented Aug 28, 2025 •

edited

Loading

NataliaIvakina commented Aug 28, 2025 •

edited

Loading

NataliaIvakina Aug 28, 2025 •

edited

Loading

NataliaIvakina Aug 28, 2025 •

edited

Loading

Hunterness Aug 29, 2025 •

edited

Loading

renetapopova Sep 8, 2025 •

edited

Loading

renetapopova Sep 8, 2025 •

edited

Loading

renetapopova Sep 8, 2025 •

edited

Loading

Hunterness Sep 10, 2025 •

edited

Loading