Skip to content

Errors and deprecations for graph references #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Lojjs
Copy link
Contributor

@Lojjs Lojjs commented Jun 10, 2025

The errors have already been merged. The deprecations come from https://github.com/neo-technology/neo4j/pull/31541

@Lojjs Lojjs added the 2025.06 label Jun 10, 2025
@@ -1246,8 +1246,10 @@ To continue using it, escape the identifier by adding backticks around the ident
To continue using it, escape the identifier by adding backticks around the identifier `%s`.
- label:new[Valid for Neo4j 5.5-5.25] All subqueries in a UNION [ALL] should have the same ordering for the return columns.
Using differently ordered return items in a UNION [ALL] clause is deprecated and will be removed in a future version.
- Databases and aliases with unescaped `.` are deprecated unless to indicate that they belong to a composite database.
- label:new[Valid for Neo4j 5.26-2025.05] Databases and aliases with unescaped `.` are deprecated unless to indicate that they belong to a composite database.
Copy link
Contributor Author

@Lojjs Lojjs Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reused the format of the label from the entry above, but that is not visible in the published docs of some reason

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this label? What do we mean by "valid" here? I almost feel like we need a "incorrectly deprecated" flag...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can discuss this comment together with @renetapopova later in the week (Lasse is out today) as I just copied it from an already existing similar place

@@ -1246,8 +1246,10 @@ To continue using it, escape the identifier by adding backticks around the ident
To continue using it, escape the identifier by adding backticks around the identifier `%s`.
- label:new[Valid for Neo4j 5.5-5.25] All subqueries in a UNION [ALL] should have the same ordering for the return columns.
Using differently ordered return items in a UNION [ALL] clause is deprecated and will be removed in a future version.
- Databases and aliases with unescaped `.` are deprecated unless to indicate that they belong to a composite database.
- label:new[Valid for Neo4j 5.26-2025.05] Databases and aliases with unescaped `.` are deprecated unless to indicate that they belong to a composite database.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this label? What do we mean by "valid" here? I almost feel like we need a "incorrectly deprecated" flag...

Comment on lines +1441 to +1443
<<_graph_reference_deprecation>>

<<_graph_reference_deprecation_use>>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links seem to not work either, even though they are to the same page 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I can see they do not work in the preview on the PR, however they do work in the Intellij ascii doc preview. Perhaps someone from docs team can figure out what I have done wrongly...

Lojjs added 2 commits June 16, 2025 14:37
- Mention parameters as the recommended approach
- Change example to use CREATE ALIAS instead of CREATE DATABASE
- Make it clearer which example queries only applies to Cypher 25
@neo4j-docops-agent
Copy link
Collaborator

This PR includes documentation updates
View the updated docs at https://neo4j-docs-status-codes-340.surge.sh

New pages:

Updated pages:

JPryce-Aklundh added a commit to neo4j/docs-cypher that referenced this pull request Jun 24, 2025
see also: neo4j/docs-status-codes#340

---------

Co-authored-by: Jens Pryce-Åklundh <112686610+JPryce-Aklundh@users.noreply.github.com>
JPryce-Aklundh added a commit to neo4j/docs-cypher that referenced this pull request Jun 24, 2025
see also: neo4j/docs-status-codes#340

---------

Co-authored-by: Jens Pryce-Åklundh <112686610+JPryce-Aklundh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants