-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
byte array support for .Net Driver #181
Conversation
@@ -34,6 +36,49 @@ public DriverIT(ITestOutputHelper output, StandAloneIntegrationTestFixture fixtu | |||
{ | |||
} | |||
|
|||
[RequireServerVersionGreaterThanOrEqualToFact("3.2.0")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can change all RequireXXServerFact
to this format instead
@@ -51,6 +51,60 @@ public Require31ServerFactAttribute() | |||
} | |||
|
|||
/// <summary> | |||
/// Use `Require32ServerFact` tag for the tests that require a server with version equals to or greater than 3.2 | |||
/// </summary> | |||
public class Require32ServerFactAttribute : FactAttribute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be removed
yo @zhenlineo how about now? |
@praveenag Thanks a lot! |
@zhenlineo Now? |
No description provided.