Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

byte array support for .Net Driver #181

Merged
merged 3 commits into from
Jun 5, 2017
Merged

byte array support for .Net Driver #181

merged 3 commits into from
Jun 5, 2017

Conversation

praveenag
Copy link
Contributor

No description provided.

@@ -34,6 +36,49 @@ public DriverIT(ITestOutputHelper output, StandAloneIntegrationTestFixture fixtu
{
}

[RequireServerVersionGreaterThanOrEqualToFact("3.2.0")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can change all RequireXXServerFact to this format instead

@@ -51,6 +51,60 @@ public Require31ServerFactAttribute()
}

/// <summary>
/// Use `Require32ServerFact` tag for the tests that require a server with version equals to or greater than 3.2
/// </summary>
public class Require32ServerFactAttribute : FactAttribute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed

@praveenag
Copy link
Contributor Author

yo @zhenlineo how about now?

@zhenlineo
Copy link
Contributor

@praveenag Thanks a lot!
A minor naming that RequireServerVersionGreaterThanOrEqualToFactAttribute can be simplified as RequireServerVersionGreaterThanOrEqualToFact.
Besides that, all looks good.

@praveenag
Copy link
Contributor Author

@zhenlineo Now?

@zhenlineo zhenlineo merged commit 47d05ce into 1.4 Jun 5, 2017
@zhenlineo zhenlineo deleted the 1.4-byte-array-dot-net branch June 5, 2017 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants